Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/no scroll with mouse #2134

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Feature/no scroll with mouse #2134

merged 2 commits into from
Jul 17, 2023

Conversation

Yosh31207
Copy link
Contributor


name: Pull Request
about: Create a pull request to help us improve
title: Add no_scroll_with_mouse option for making window and child window.
assignees: ''


Closes #2133

Description:

Added no_scroll_with_mouse option for the following functions:

def window(..., no_scroll_with_mouse: bool = False):
def add_window(..., no_scroll_with_mouse: bool = False):
def child_window(..., no_scroll_with_mouse: bool = False):
def add_child_window(..., no_scroll_with_mouse: bool = False):

This option makes window with Dear ImGui's ImGuiWindowFlags_NoScrollWithMouse flag.

Concerning Areas:

@Atlamillias
Copy link
Contributor

Beat me too it lol. My fault for not paying attention.

@hoffstadt @Pcothren If this PR is accepted please block #2136 (or discard the related commits).

@hoffstadt hoffstadt merged commit 4b0b913 into hoffstadt:master Jul 17, 2023
4 checks passed
@Yosh31207 Yosh31207 deleted the feature/no_scroll_with_mouse branch July 17, 2023 04:11
SamuMazzi pushed a commit to SamuMazzi/DearPyGui that referenced this pull request Jan 31, 2024
* feat: add no_scroll_with_mouse flag for window() and add_window() hoffstadt#2133

* feat: add no_scroll_with_mouse flag for child() and add_child() hoffstadt#2133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add no_scroll_with_mouse option for window() and child_window()
3 participants