fix: custom series delete crash issue #1864

hoffstadt · Oct 22, 2022 · 3361292 · 3361292
1 parent 6630615
commit 3361292
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/src/dearpygui_commands.h b/src/dearpygui_commands.h
@@ -2999,7 +2999,8 @@ delete_item(PyObject* self, PyObject* args, PyObject* kwargs)
 
 	mvUUID item = GetIDFromPyObject(itemraw);
 
-	DeleteItem((*GContext->itemRegistry), item, childrenOnly, slot);
+    if(item != 0)
+	    DeleteItem((*GContext->itemRegistry), item, childrenOnly, slot);
 
 	return GetPyNone();
 

diff --git a/src/mvPythonTranslator.cpp b/src/mvPythonTranslator.cpp
@@ -273,9 +273,11 @@ ToPyList(const std::vector<double>& value)
 
     PyObject* result = PyList_New(value.size());
 
-    for (size_t i = 0; i < value.size(); ++i)
-        PyList_SetItem(result, i, PyFloat_FromDouble(value[i]));
-
+    if(result)
+    {
+        for (size_t i = 0; i < value.size(); ++i)
+            PyList_SetItem(result, i, PyFloat_FromDouble(value[i]));
+    }
     return result;
 }
 
@@ -284,8 +286,11 @@ ToPyList(const std::vector<std::vector<float>>& value)
 {
     PyObject* result = PyList_New(value.size());
 
-    for (size_t i = 0; i < value.size(); ++i)
-        PyList_SetItem(result, i, ToPyList(value[i]));
+    if(result)
+    {
+        for (size_t i = 0; i < value.size(); ++i)
+            PyList_SetItem(result, i, ToPyList(value[i]));
+    }
 
     return result;
 }
@@ -295,8 +300,11 @@ ToPyList(const std::vector<std::vector<double>>& value)
 {
     PyObject* result = PyList_New(value.size());
 
-    for (size_t i = 0; i < value.size(); ++i)
-        PyList_SetItem(result, i, ToPyList(value[i]));
+    if(result)
+    {
+        for (size_t i = 0; i < value.size(); ++i)
+            PyList_SetItem(result, i, ToPyList(value[i]));
+    }
 
     return result;
 }