fix: removing untemplated labels #82
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #82 +/- ##
========================================
Coverage 80.77% 80.77%
========================================
Files 13 13
Lines 1233 1233
========================================
Hits 996 996
Misses 237 237 |
deantchi
had a problem deploying
to
Development
GitHub Actions
Failure
|
@deantchi This doesn't seem to explain why this change is being made? |
original description updated with reason for change. |
There was a problem hiding this comment.
For the interest of unblocking you I'm happy to approve, but this is a bug that should be addressed in an issue. @deantchi would you mind creating that?
@deantchi You could try your hand at a code fix, using the functions which deploy devnet workloads as a reference since they do use the user_id var. Otherwise Ludo could possibly help here.
challenge accepted! |
## [1.1.0](v1.0.0...v1.1.0) (2024-03-25) ### Features * allow config path to be configured via env var ([#67](#67)) ([483fb8b](483fb8b)) * allow configuring k8s context with env var ([#71](#71)) ([f7e6bc3](f7e6bc3)) * check auth header before allowing access ([#47](#47)) ([6dcb36d](6dcb36d)) * remove pods; implement deployments/stateful sets ([#75](#75)) ([6399c19](6399c19)) * status page at `GET /` and `GET /api/v1/status` routes ([#68](#68)) ([d4c2290](d4c2290)) * upgrade clarinet to v2.4.0; enable `use_nakamoto` field to configure stacks chain for nakamoto ([#89](#89)) ([521acd1](521acd1)) * upgrade to using clarinet crate to parse config ([#46](#46)) ([d57d3a1](d57d3a1)) ### Bug Fixes * add ACCESS_CONTROL_ALLOW_HEADERS to response header ([#52](#52)) ([225d2c9](225d2c9)) * add subPath for postgres volume mount ([#73](#73)) ([7812741](7812741)) * api container spelling fix ([7b52f93](7b52f93)) * don't require auth on OPTIONS requests; configure user-id prefix to make namespace ([#51](#51)) ([9fe7972](9fe7972)) * reduce permissions for cluster role ([#54](#54)) ([2ea50ea](2ea50ea)) * removing untemplated labels ([#82](#82)) ([e92dcb5](e92dcb5)) * set img pull policy for stacks blockchain api ([0b959c2](0b959c2)) * template ([#85](#85)) ([4399177](4399177))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
{{user_id}}label is not critical in the configmaps as they are all the same for every devnet deploymentthe devnet-api not accounting for and replacing the '{[user_id}}' in the configmaps will break deployments. '{{user_id}}' will be treated as literal which is violates constraints. see here