Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Clarinet to 2.9.0, & use default chain tip values #102

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

leahjlou
Copy link
Collaborator

@leahjlou leahjlou commented Oct 1, 2024

  • Upgrade Clarinet to 2.9.0 and update Devnet config to reflect new fields
  • When fetching the status of a devnet (GET /api/v1/network/<name>), and the chain is unavailable, handle errors by using default values of 0 for the chain tip in the response body (Previously, this was returning a 500)

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib.rs 51.72% 14 Missing ⚠️

📢 Thoughts on this report? Let us know!

@leahjlou leahjlou changed the title Upgrade Clarinet to latest [WIP] Upgrade Clarinet to latest Oct 2, 2024
@leahjlou leahjlou changed the title [WIP] Upgrade Clarinet to latest Upgrade Clarinet to latest Oct 2, 2024
@leahjlou leahjlou changed the title Upgrade Clarinet to latest Upgrade Clarinet to 2.9.0, & use default chain tip values Oct 3, 2024
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some change request, mostly about formatting

Dockerfile Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hugocaillard hugocaillard self-requested a review October 3, 2024 16:34
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @leahjlou

@leahjlou leahjlou merged commit 5ddbe10 into develop Oct 3, 2024
3 checks passed
@leahjlou leahjlou deleted the feat/upgrade-clarinet branch October 3, 2024 18:46
@blockstack-devops
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants