Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use the API toolkit, upgrade to node 18 #1743

Merged
merged 27 commits into from
Oct 31, 2023
Merged

Conversation

rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Oct 24, 2023

  • Move value conversion helpers to API toolkit
  • Upgrade typescript, ts-node, ts-jest, etc.
  • Move semantic release config to .releaserc
  • Upgrade stacks.js
  • Upgrade Dockerfiles
  • Upgrade Github actions to latest versions to get rid of node 12 warnings in Github

package.json Outdated Show resolved Hide resolved
@rafaelcr rafaelcr temporarily deployed to Preview October 27, 2023 16:45 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Vercel deployment URL: https://stacks-blockchain-1fh5axhr9-blockstack.vercel.app 🚀

@rafaelcr rafaelcr temporarily deployed to Preview October 27, 2023 16:52 — with GitHub Actions Inactive
@rafaelcr rafaelcr temporarily deployed to Preview October 27, 2023 17:03 — with GitHub Actions Inactive
@rafaelcr rafaelcr temporarily deployed to Preview October 27, 2023 17:08 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1743 (3ea5797) into nakamoto (1d86e3c) will increase coverage by 0.33%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##           nakamoto    #1743      +/-   ##
============================================
+ Coverage     71.67%   72.00%   +0.33%     
============================================
  Files            90       88       -2     
  Lines         12330    11951     -379     
  Branches       2684     2581     -103     
============================================
- Hits           8837     8605     -232     
+ Misses         3329     3192     -137     
+ Partials        164      154      -10     
Files Coverage Δ
src/api/controllers/cache-controller.ts 94.59% <100.00%> (+0.04%) ⬆️
src/api/init.ts 83.63% <100.00%> (+0.81%) ⬆️
src/api/query-helpers.ts 86.57% <100.00%> (+0.09%) ⬆️
src/api/rosetta-validate.ts 87.32% <100.00%> (+0.18%) ⬆️
src/api/routes/address.ts 88.23% <100.00%> (+0.04%) ⬆️
src/api/routes/block.ts 90.76% <100.00%> (ø)
src/api/routes/info.ts 100.00% <100.00%> (ø)
src/api/routes/microblock.ts 96.96% <100.00%> (ø)
src/api/routes/rosetta/account.ts 92.39% <100.00%> (ø)
src/api/routes/rosetta/block.ts 85.00% <100.00%> (ø)
... and 37 more

... and 3 files with indirect coverage changes

@rafaelcr rafaelcr temporarily deployed to Preview October 27, 2023 17:14 — with GitHub Actions Inactive
@rafaelcr rafaelcr temporarily deployed to Preview October 27, 2023 17:22 — with GitHub Actions Inactive
@rafaelcr rafaelcr temporarily deployed to Preview October 27, 2023 17:29 — with GitHub Actions Inactive
@rafaelcr rafaelcr temporarily deployed to Preview October 27, 2023 17:45 — with GitHub Actions Inactive
@rafaelcr rafaelcr temporarily deployed to Preview October 27, 2023 17:48 — with GitHub Actions Inactive
@rafaelcr rafaelcr temporarily deployed to Preview October 30, 2023 14:59 — with GitHub Actions Inactive
@rafaelcr rafaelcr temporarily deployed to Preview October 31, 2023 02:12 — with GitHub Actions Inactive
@rafaelcr rafaelcr temporarily deployed to Preview October 31, 2023 14:27 — with GitHub Actions Inactive
@rafaelcr rafaelcr marked this pull request as ready for review October 31, 2023 14:32
@rafaelcr rafaelcr requested a review from csgui October 31, 2023 14:32
Copy link
Collaborator

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @rafaelcr !

That is an important upgrade to the stacks-api.

I've checked locally and it seems to be ok. Despite of being a huge PR it's mainly refactoring stuff. Well done!

@rafaelcr rafaelcr merged commit 74606c7 into nakamoto Oct 31, 2023
31 checks passed
@rafaelcr rafaelcr deleted the chore/toolkit branch October 31, 2023 19:05
@blockstack-devops
Copy link

🎉 This PR is included in version 7.4.0-nakamoto.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blockstack-devops
Copy link

🎉 This PR is included in version 7.6.0-nakamoto.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blockstack-devops
Copy link

🎉 This PR is included in version 7.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants