Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/poison microblock #1684

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Test/poison microblock #1684

merged 3 commits into from
Jul 13, 2023

Conversation

timstackblock
Copy link
Contributor

@timstackblock timstackblock commented Jul 6, 2023

Description

Addition of test to that will close issue #1681 . We are backfilling test related to incidents to improve quality.

  1. Test was missing for issue related to an incident
  2. A tsv file was added for a poison microblock and a new test script was added under event replay
  3. This should not impact development
  4. Link to relevant issues and documentation

For details refer to issue #1681

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

No this PR does not introduce a breaking change

Are documentation updates required?

NO

Testing information

When you launch event replay test in VS Code this test will run

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @rafaelcr or @zone117x for review

test script to check for api crash from poison microblock
tsv file for poison microblock
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

@github-actions github-actions bot temporarily deployed to pull request July 6, 2023 13:55 Inactive
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1684 (7106757) into master (e39f7e3) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
+ Coverage   77.10%   77.20%   +0.09%     
==========================================
  Files          78       78              
  Lines       11253    11253              
  Branches     2511     2511              
==========================================
+ Hits         8677     8688      +11     
+ Misses       2454     2443      -11     
  Partials      122      122              

see 3 files with indirect coverage changes

query txs table verify poison microblock tx ingested
@github-actions github-actions bot temporarily deployed to pull request July 11, 2023 13:58 Inactive
@github-actions github-actions bot temporarily deployed to commit July 11, 2023 13:58 Inactive
@zone117x zone117x merged commit 24bc11b into master Jul 13, 2023
30 checks passed
@zone117x zone117x deleted the test/posion-microblock branch July 13, 2023 15:49
@blockstack-devops
Copy link

🎉 This PR is included in version 7.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants