Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update openapi description #307

Merged
merged 5 commits into from
Feb 13, 2024
Merged

update openapi description #307

merged 5 commits into from
Feb 13, 2024

Conversation

ryanwaits
Copy link
Contributor

Description

Add additional content to the OpenAPI description section to match the Ordinals API Overview page and to improve SEO

Copy link

github-actions bot commented Feb 12, 2024

Vercel deployment URL: https://ordinals-3y62nwd24-blockstack.vercel.app 🚀

Copy link
Contributor

@max-crawford max-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/api/schemas.ts Outdated Show resolved Hide resolved
src/api/schemas.ts Outdated Show resolved Hide resolved
src/api/schemas.ts Outdated Show resolved Hide resolved
src/api/schemas.ts Outdated Show resolved Hide resolved
src/api/schemas.ts Outdated Show resolved Hide resolved
Co-authored-by: max-crawford <[email protected]>
Co-authored-by: max-crawford <[email protected]>
Co-authored-by: max-crawford <[email protected]>
Co-authored-by: max-crawford <[email protected]>
Copy link
Contributor

@max-crawford max-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanwaits per Rafael's feedback we should remove the section on running the Ordinals API here. I tried to make those suggestions in the PR, but not sure if I formatted them correctly.

@ryanwaits
Copy link
Contributor Author

preview looks good

Copy link
Contributor

@max-crawford max-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@diwakergupta diwakergupta merged commit ebde669 into develop Feb 13, 2024
7 checks passed
@diwakergupta diwakergupta deleted the docs/add-overview-content branch February 13, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants