Chore: update gitignore #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, thank you for this. The precommit hook generates the zip files and includes them in your commit always. I think there is definitely a better approach (in general, I don't like precommit hooks adding things to your commit automatically), but I had limited time to get something in here that would help contributions go more smoothly. It's on my list to revisit this. #15 |
leahjlou
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leahjlou Couldn't help but notice that node_modules were on git, so removed it.
PS: Also noticing that git says I update the zip files in the PR, so did I actually forgot to push in my previous PR like Sabby said 🤔