Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve precommit hook #15

Open
leahjlou opened this issue Mar 17, 2023 · 0 comments
Open

Improve precommit hook #15

leahjlou opened this issue Mar 17, 2023 · 0 comments

Comments

@leahjlou
Copy link
Collaborator

The precommit hook currently generates the metadata.json and zips and adds them to the commit. In general, I think precommit hooks shouldn't add things to your commit automatically. This should be revisited: maybe the hook should fail if there are changes to relevant files, and instruct the developer to run the build command before commiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant