Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow stacks-network to be run as standalone chain coordinator #1064

Merged
merged 54 commits into from
Aug 29, 2023
Merged

feat: allow stacks-network to be run as standalone chain coordinator #1064

merged 54 commits into from
Aug 29, 2023

Conversation

MicaiahReid
Copy link
Contributor

No description provided.

@MicaiahReid MicaiahReid changed the title feat: split stacks-network to allow standalone chain coordination feat: alone stacks-network to be run as standalone chain coordinator Jul 4, 2023
@MicaiahReid MicaiahReid marked this pull request as ready for review July 4, 2023 00:12
@MicaiahReid MicaiahReid changed the title feat: alone stacks-network to be run as standalone chain coordinator feat: alow stacks-network to be run as standalone chain coordinator Jul 5, 2023
@MicaiahReid MicaiahReid changed the title feat: alow stacks-network to be run as standalone chain coordinator feat: allow stacks-network to be run as standalone chain coordinator Jul 5, 2023
hugocaillard
hugocaillard previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I don't have a lot of experience on stacks-network and stacks-devnet so I think @lgalabru should have a look

lgalabru
lgalabru reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, thanks @MicaiahReid!
Could you also please tell us more about the current status of clarinet integrate and stacks-devnet-js? Are these 2 features still functional?
Thanks!

@MicaiahReid MicaiahReid mentioned this pull request Jul 19, 2023
Closed
6 tasks
@MicaiahReid
Copy link
Contributor Author

@lgalabru, I've confirmed that both clarinet integrate and stacks-devnet-js still work as expected!

@MicaiahReid
separate event and log modules for stacks-network
b95f91a
@MicaiahReid
add separate functions for instantiating orchestrator
d881ddf
@MicaiahReid
move event/log
0414abd
@MicaiahReid
make do_run_devnet able to run for devnet service
7e7e95c
@MicaiahReid
have clarinet integrate run local devnet version
21c6236
@MicaiahReid
add ability to run a non-local devnet service
2db8c06
@MicaiahReid
dockerfile for stacks-network image
bc4173d
@MicaiahReid
spelling on logging
4d48eda
@MicaiahReid
fix url
3540eef
@MicaiahReid
some renaming
7a6bac4
@MicaiahReid
fix imports for stacks-devnet-js
d15eac9
@MicaiahReid
remove working_dir override
0f6c053
@MicaiahReid
remove unused import
1fa3906
@MicaiahReid
fix logging for devnet
7fd3ed3
@MicaiahReid
use same builder as other docker images
3f12b34
@MicaiahReid
add serde_yaml dep
f796675
@MicaiahReid
reduce how many times network manifest is read from disk
1a54e6a
@MicaiahReid
read files directly, not using _File type
c33d244
@MicaiahReid
add default project_manifest cache_location
4eb88b1
@MicaiahReid
fix stacks-devnet-js
1923dac
@MicaiahReid MicaiahReid changed the base branch from develop to devnet-package August 28, 2023 17:36
lgalabru
lgalabru previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks @MicaiahReid!

Base automatically changed from devnet-package to develop August 29, 2023 15:28
@lgalabru lgalabru dismissed their stale review August 29, 2023 15:28

The base branch was changed.

@lgalabru lgalabru merged commit 55b03bb into develop Aug 29, 2023
11 of 15 checks passed
@lgalabru lgalabru deleted the feat/integrate-devnet branch August 29, 2023 17:49
hugocaillard added a commit that referenced this pull request Sep 6, 2023
@hugocaillard
Revert "feat: allow stacks-network to be run as standalone chain coor…
b3d1b83 
…dinator (#1064)"

This reverts commit 55b03bb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgalabru lgalabru lgalabru left review comments

@hugocaillard hugocaillard hugocaillard left review comments

Assignees

@lgalabru lgalabru

Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MicaiahReid @CAGS295 @lgalabru @hugocaillard @csgui