Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control list filters #323

Open
wants to merge 43 commits into
base: dev
Choose a base branch
from
Open

Control list filters #323

wants to merge 43 commits into from

Conversation

Juliettejns
Copy link
Contributor

Issue #180: Allow regular expressions to filter tokens

  • Création d'une nouvelle route pour les filtres de control-lists
  • Modification de la fonction get_unallowed avec filtres
  • modifications du template pour ajouter les filtres

Juliettejns and others added 5 commits March 21, 2024 15:19
* Add more details about the lemmatizer at the new corpus phase.
* Add test for lemmatization services
* Add more verbosity because tests hang
* Remove various screenshots
@Juliettejns Juliettejns changed the title Dev controllist Control list filters Jun 13, 2024
@Juliettejns
Copy link
Contributor Author

  • Ajout de nouvelles colonnes dans la table ControlList (booléen pour chaque filtre)
  • Ajout d'une nouvelle template ignore_filtre pour que l'utilisateur puisse modifier les filtres qu'il souhaite et modification du form de création d'un corpus
  • Lien entre la modification d'un corpus déjà existant et les filtres
  • Ajout des filtres pour la modification des tokens
    En cours:
  • Ajout des filtres pour l'affichage des tokens invalides (problème dans la regex, à terminer)
  • Modification filtres pour les corpus créés ex nihilo
  • Ajustements (pb visuels sur la template - manque le menu, modifier la description des filtres..., enlever les réglages de tests

@Juliettejns
Copy link
Contributor Author

A faire:

  • aspects physiques templates
  • tests

@Juliettejns
Copy link
Contributor Author

  • problème de tests corrigé
  • manque tests spécifiques aux ajouts

@Juliettejns
Copy link
Contributor Author

Les tests ne fonctionnent pas, c'est un premier jet

@Juliettejns
Copy link
Contributor Author

Tests selenium qui bug sur github mais pas en local... A retravailler

@PonteIneptique
Copy link
Member

@Juliettejns Je ne suis toujours pas sûr de l'utilisation de ControlListUser plutôt que de ControlList directement.

@main.route('/corpus/new', methods=["POST", "GET"])
@login_required
def corpus_new():
""" Register a new corpus
"""
logging.basicConfig(filename='./pyrrha_corpus_creation.log', level=logging.DEBUG,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La basic config devrait avoir lieu ailleurs je pense... Par exemple, dans create_app

Copy link
Member

@PonteIneptique PonteIneptique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requests:

  • Move ControlListUser to ControlList
  • Add combinatory tests for WordToken.is_valid using various regex.

app/main/views/tokens.py Outdated Show resolved Hide resolved
app/models/corpus.py Outdated Show resolved Hide resolved
app/models/corpus.py Outdated Show resolved Hide resolved
app/templates/control_lists/macros.html Outdated Show resolved Hide resolved
tests/test_selenium/test_token_correct.py Show resolved Hide resolved
app/control_lists/views.py Outdated Show resolved Hide resolved
app/main/views/tokens.py Outdated Show resolved Hide resolved
app/models/control_lists.py Outdated Show resolved Hide resolved
app/models/corpus.py Outdated Show resolved Hide resolved
app/models/corpus.py Outdated Show resolved Hide resolved
app/models/corpus.py Outdated Show resolved Hide resolved
app/models/corpus.py Outdated Show resolved Hide resolved
tests/test_selenium/test_control_lists.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants