Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update psyclone to support next release syntax #24

Open
wants to merge 4 commits into
base: bom_master
Choose a base branch
from

Conversation

hiker
Copy link
Owner

@hiker hiker commented Oct 1, 2024

Support the new/future PSyclone command line options.

@hiker
Copy link
Owner Author

hiker commented Oct 1, 2024

Hi Luke, with Jason being out for some time, I need you to review this PR. I have verified that it works as expected with Jason's lfric_atm-fab work.

Background: the next PSyclone release will change command line options:
-api dynamo0.3 --> --psykal-dsl lfric
-api gocean1.0--> --psykal-dsl gocean
-api nemo --> new default, so no option required. BUT the output filename must then be specified using -o instead of -opsy

To make this change even more annoying: the psyclone version number does not change on trunk (and ng-arch needs trunk). While we are working on a new release (and discussing a way to add a specific version number for trunk), for now there is no easy way to identify if psyclone version 2.5.0 is the release, or current trunk.

So this patch adds:

  • determining the PSyclone version number. If the version is 2.5.0, it tries to run the old style -api nemo option. If this is an error, we know it is current trunk, and we set the version number to 2.5.0.1
  • Old style and new style options will be mapped (depending on version number). E.g. if nemo is specified, and we are on current trunk, we will not add any -api (i.e. remove the nemo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant