color picker + misc bug fix #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempting a fix for #44
hiddenist
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
note for myself: https://github.com/hiddenist/drawing-app/actions/runs/7156473524 |
hiddenist
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hiddenist
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hiddenist
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Also adds a makeLayer, which is a refactor, not a fix. I don't want to hear any sass. It's my side project and I can be as messy as I want 😤 Plus, vscode doesn't give me an easy interface to only commit specific lines. I'm guessing there's a plugin that can do that, but... that would require me actually looking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where, when selecting a color on mobile, the canvas is cleared out on the next draw.
It also fixes these problems:
Closes #44