Fix MPI issue with vmec crashes in 1st evaluation #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 92.52% 92.61% +0.09%
==========================================
Files 75 75
Lines 13830 13837 +7
==========================================
+ Hits 12796 12815 +19
+ Misses 1034 1022 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vmec fails to converge on the first function evaluation of an optimization, MPI proc 0 exits with an uncaught exception while other procs do not, causing the code to hang due to the MPI communication getting out of sync. This can result is wasted time on the cluster, as jobs don't exit cleanly and keep occupying nodes even though they are not actually working on an optimization. This PR fixes this issue, and the new test here provides coverage for this issue.