Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to unittest. #373

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix to unittest. #373

merged 1 commit into from
Oct 30, 2023

Conversation

ejpaul
Copy link
Contributor

@ejpaul ejpaul commented Oct 30, 2023

This PR is in response to #371. Assert statements have now been included in the unit tests for the LPTorsionalStrainPenalty and LPBinormalCurvatureStrainPenalty.

@ejpaul ejpaul mentioned this pull request Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10daafb) 91.38% compared to head (65c2ebe) 91.02%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   91.38%   91.02%   -0.37%     
==========================================
  Files          72       72              
  Lines       12700    12700              
==========================================
- Hits        11606    11560      -46     
- Misses       1094     1140      +46     
Flag Coverage Δ
unittests 91.02% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mbkumar mbkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejpaul
Thanks for the quick fix

@mbkumar mbkumar closed this Oct 30, 2023
@mbkumar mbkumar reopened this Oct 30, 2023
@mbkumar mbkumar merged commit 065bef6 into master Oct 30, 2023
57 of 59 checks passed
@mbkumar mbkumar deleted the strain_opt_fix branch October 30, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants