Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poincare options #362

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Poincare options #362

merged 2 commits into from
Oct 6, 2023

Conversation

ejpaul
Copy link
Contributor

@ejpaul ejpaul commented Oct 6, 2023

The PR adds a few more keyword arguments for Poincare plotting. With the default option, the marker size can sometimes be too large to see details of the plot.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

Comparison is base (705053a) 90.66% compared to head (51b37b4) 91.46%.
Report is 474 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   90.66%   91.46%   +0.80%     
==========================================
  Files          65       72       +7     
  Lines       11030    12825    +1795     
==========================================
+ Hits        10000    11730    +1730     
- Misses       1030     1095      +65     
Flag Coverage Δ
unittests 91.46% <93.58%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/simsopt/_core/__init__.py 100.00% <100.00%> (ø)
src/simsopt/_core/derivative.py 98.90% <100.00%> (ø)
src/simsopt/_core/finite_difference.py 94.06% <100.00%> (+0.90%) ⬆️
src/simsopt/_core/json.py 83.67% <100.00%> (+0.59%) ⬆️
src/simsopt/_core/optimizable.py 90.35% <100.00%> (+0.19%) ⬆️
src/simsopt/field/__init__.py 100.00% <100.00%> (ø)
src/simsopt/field/biotsavart.py 95.52% <100.00%> (-0.04%) ⬇️
src/simsopt/field/magneticfield.py 99.27% <100.00%> (+0.13%) ⬆️
src/simsopt/field/magneticfieldclasses.py 97.35% <100.00%> (+1.34%) ⬆️
src/simsopt/field/normal_field.py 92.20% <100.00%> (+2.59%) ⬆️
... and 35 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ejpaul ejpaul requested a review from mbkumar October 6, 2023 21:01
@mbkumar mbkumar merged commit 490282b into master Oct 6, 2023
47 checks passed
@mbkumar mbkumar deleted the poincare_options branch October 6, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants