Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenCL Model #744

Open
wants to merge 23 commits into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 19 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 109 additions & 0 deletions cat/c11-partialsc.cat
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
C "C++11"

(*
* Overhauling SC atomics in C11 and OpenCL.
* M. Batty, A. Donaldson, J. Wickerson. In Proc.
* 43rd ACM SIGPLAN-SIGACT Symposium on Principles of Programming Languages (POPL), 2016.
*)

(*
* This model is based on:
* https://multicore.doc.ic.ac.uk/overhauling/c11_base.cat
* https://multicore.doc.ic.ac.uk/overhauling/c11_partialSC.cat
*)

include "basic.cat"
include "c11_cos.cat"
include "c11_los.cat"

let asw = IW * (M \ IW)
let sb = po
let mo = co & (~NAL * ~NAL)

let cacq = ACQ | (SC & (R | F)) | ACQ_REL | (F & CON)
let crel = REL | (SC & (W | F)) | ACQ_REL
let ccon = R & CON

// To be compatible with reads from uninit memory, we use our default definition of fr
//let fr = rf^-1 ; mo
Comment on lines +27 to +28
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without init events, the initial memory is neither tagged NONATOMIC nor NON_ATOMIC_LOCATION. I think this might cause issues.


let dd = (data | addr)+

let fsb = [F] ; sb
let sbf = sb ; [F]

(* release_acquire_fenced_synchronizes_with, hypothetical_release_sequence_set, release_sequence_set *)

(* OLD: let rs = [crel] ; fsb? ; [A & W] ; (((mo ; [rmw]) | coi) & ~(coe ; [!rmw] ; mo))? *)
let rs_prime = int | (_ * (R & W))
let rs = mo & rs_prime \ ((mo \ rs_prime) ; mo)

(* OLD: let swra = ext & (rs ; rf ; [A] ; sbf? ; [cacq]) *)
let swra = ext & ([crel] ; fsb? ; [A & W] ; rs? ; rf ; [R & A] ; sbf? ; [cacq])

//let swul = ext & ([UL] ; lo ; [LK])
let pp_asw = asw \ (asw ; sb)
//let sw = pp_asw | swul | swra
let sw = pp_asw | swra

(* with_consume_cad_set, dependency_ordered_before *)
let cad = ((rf & sb) | dd)+
let dob = (ext & ([W & crel] ; fsb? ; [A & W] ; rs?; rf; [ccon])); cad?

(* happens_before, inter_thread_happens_before, consistent_hb *)
let ithbr = sw | dob | (sw ; sb)
let ithb = (ithbr | (sb ; ithbr))+
let hb = sb | ithb
acyclic hb as Hb

(* coherent_memory_use *)
let hbl = hb & loc

irreflexive ((rf^-1)? ; mo ; rf? ; hb) as Coh

(* visible_side_effect_set *)
let vis = ([W] ; hbl ; [R]) & ~(hbl; [W]; hbl)

(* consistent_atomic_rf *)
irreflexive (rf ; hb) as Rf

(* consistent_non_atomic_rf *)
empty ((rf ; [NAL]) \ vis) as NaRf

(* Consistency of RMWs *)
empty rmw & (fre; coe) as atomic
// The original model was tested with Herd, which treats RMW as a single atomic operation.
// We have modified the model to handle RMW as a sequence of atomic operations.
// irreflexive (rf | (mo ; mo ; rf^-1) | (mo ; rf)) as Rmw


(* locks_only_consistent_lo *)
// irreflexive (lo ; hb) as Lo1

(* locks_only_consistent_locks *)
// irreflexive ([LS] ; lo^-1 ; [LS] ; ~(lo ; [UL] ; lo)) as Lo2

(* data_races *)
let cnf = ((W * _) | (_ * W)) & loc
let dr = ext & (cnf \ hb \ (hb^-1) \ (A * A))

(* unsequenced_races *)
let ur = int & ((W * M) | (M * W)) & loc & ~id & ~(sb+) & ~((sb+)^-1)

(* locks_only_good_mutex_use, locks_only_bad_mutexes *)
// let bl = ([LS]; (sb & lo); [LK]) & ~(lo; [UL]; lo)
// let losbwoul = (sb & lo & ~(lo; [UL]; lo))
// let lu = [UL] & ~([UL] ; losbwoul^-1 ; [LS] ; losbwoul ; [UL])

(* Partial SC axioms *)
let r1 = hb
let r2 = fsb? ; mo ; sbf?
let r3 = rf^-1; [SC] ; mo
let r4 = rf^-1 ; hbl ; [W]
let r5 = fsb ; fr
let r6 = fr ; sbf
let r7 = fsb ; fr ; sbf

let scp = r1|r2|r3|r4|r5|r6|r7

acyclic (((SC * SC) & scp) \ id) as Spartial
119 changes: 42 additions & 77 deletions cat/c11.cat
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
C "C++11"

(* All c11_*.cat files are C11 models
Overhauling SC atomics in C11 and OpenCL.
M. Batty, A. Donaldson, J. Wickerson. In Proc.
43rd ACM SIGPLAN-SIGACT Symposium on Principles of Programming Languages (POPL), 2016.

Rewritten by Luc Maranget for herd7

(*
* Overhauling SC atomics in C11 and OpenCL.
* M. Batty, A. Donaldson, J. Wickerson. In Proc.
* 43rd ACM SIGPLAN-SIGACT Symposium on Principles of Programming Languages (POPL), 2016.
*)

(*
This is an adapted version of C11 that supports an execution model where explicit init events
may be missing. As a consequence, reads may have no rf-edge if they read from initial memory.
* This model is based on:
* https://multicore.doc.ic.ac.uk/overhauling/c11_base.cat
* https://multicore.doc.ic.ac.uk/overhauling/c11_simp.cat
*)

include "basic.cat"
Expand All @@ -20,7 +18,7 @@ include "c11_los.cat"

let asw = IW * (M \ IW)
let sb = po
let mo = co
let mo = co & (~NAL * ~NAL)

let cacq = ACQ | (SC & (R | F)) | ACQ_REL | (F & CON)
let crel = REL | (SC & (W | F)) | ACQ_REL
Expand All @@ -31,42 +29,28 @@ let ccon = R & CON

let dd = (data | addr)+

let fsb = sb & (F * _)
let sbf = sb & (_ * F)
let fsb = [F] ; sb
let sbf = sb ; [F]

(* release_acquire_fenced_synchronizes_with,
hypothetical_release_sequence_set,
release_sequence_set *)

(* OLD: let rs = [crel] ; fsb? ; [A & W] ;
(((mo ; [rmw]) | coi) & ~(coe ; [!rmw] ; mo))? *)
(* release_acquire_fenced_synchronizes_with, hypothetical_release_sequence_set, release_sequence_set *)

(* OLD: let rs = [crel] ; fsb? ; [A & W] ; (((mo ; [rmw]) | coi) & ~(coe ; [!rmw] ; mo))? *)
let rs_prime = int | (_ * (R & W))
let rs = mo & rs_prime \ ((mo \ rs_prime) ; mo)

(* OLD: let swra = ext (rs ; rf ; [A] ; sbf? ; [cacq]) *)
let swra =
ext &
([crel] ; fsb? ; [A & W] ; rs? ; rf ;
[R & A] ; sbf? ; [cacq])
(* OLD: let swra = ext & (rs ; rf ; [A] ; sbf? ; [cacq]) *)
let swra = ext & ([crel] ; fsb? ; [A & W] ; rs? ; rf ; [R & A] ; sbf? ; [cacq])

//let swul = ext & ([UL] ; lo ; [LK])
let pp_asw = asw \ (asw ; sb)
//let sw = pp_asw | swul | swra
let sw = pp_asw | swra

(* with_consume_cad_set,
dependency_ordered_before *)
(* with_consume_cad_set, dependency_ordered_before *)
let cad = ((rf & sb) | dd)+
let dob =
(ext &
([W & crel] ; fsb? ; [A & W] ;
rs?; rf; [ccon]));
cad?

(* happens_before,
inter_thread_happens_before,
consistent_hb *)
let dob = (ext & ([W & crel] ; fsb? ; [A & W] ; rs?; rf; [ccon])); cad?

(* happens_before, inter_thread_happens_before, consistent_hb *)
let ithbr = sw | dob | (sw ; sb)
let ithb = (ithbr | (sb ; ithbr))+
let hb = sb | ithb
Expand All @@ -75,63 +59,44 @@ acyclic hb as Hb
(* coherent_memory_use *)
let hbl = hb & loc

// irreflexive ((rf^-1)? ; mo ; rf? ; hb) as Coh
// To support reads from uninitialized memory
irreflexive ((fr | mo) ; rf? ; hb) as Coh
irreflexive ((fr | mo); rf?; hb) as Coh

(* visible_side_effect_set *)
let vis = (hbl & (W * R)) \ (hbl; [W] ; hbl)
let vis = ([W] ; hbl ; [R]) & ~(hbl; [W]; hbl)

(* consistent_atomic_rf *)
irreflexive (rf ; hb) as Rf

(* consistent_non_atomic_rf *)
empty ((rf ; [R\A]) \ vis) as NaRf
// NOTE FW is a dynamic tag which we don't yet support
//empty [FW\A];hbl;[W] as NaRf (* implicit read of Na final writes.. *)

irreflexive (rf | (mo ; mo ; rf^-1) | (mo ; rf)) as Rmw
empty ((rf ; [NAL]) \ vis) as NaRf

(* Consistency of RMWs *)
empty rmw & (fre; coe) as atomic
// The original model was tested with Herd, which treats RMW as a single atomic operation.
// We have modified the model to handle RMW as a sequence of atomic operations.
// irreflexive (rf | (mo ; mo ; rf^-1) | (mo ; rf)) as Rmw

(* locks_only_consistent_lo *)
//irreflexive (lo ; hb) as Lo1
// irreflexive (lo ; hb) as Lo1

(* locks_only_consistent_locks *)
//irreflexive ([LS] ; lo^-1 ; [LS] ; ~(lo ; [UL] ; lo)) as Lo2

// irreflexive ([LS] ; lo^-1 ; [LS] ; ~(lo ; [UL] ; lo)) as Lo2

(* data_races *)
//let Mutex = UL|LS
//let cnf = (((W * _) | (_ * W)) & loc) \ ((Mutex * _) | (_ * Mutex))
//let dr = ext & (cnf \ hb \ (hb^-1) \ (A * A))
let cnf = ((W * _) | (_ * W)) & loc
let dr = ext & (cnf \ hb \ (hb^-1) \ (A * A))

(* unsequenced_races *)
//let ur = int & ((W * M) | (M * W)) & loc & ~id & ~(sb+) & ~((sb+)^-1)

(* locks_only_good_mutex_use, locks_only_bad_mutexes *)

//let bl = ([LS]; (sb & lo); [LK]) & ~(lo; [UL]; lo)

//let losbwoul = (sb & lo & ~(lo; [UL]; lo))

//let lu = [UL] & ~([UL] ; losbwoul^-1 ; [LS] ; losbwoul ; [UL])

let r1 = hb
let r2 = fsb? ; mo ; sbf?
let r3 = rf^-1; [SC] ; mo
let r4 = rf^-1 ; hbl ; [W]
let r5 = fsb ; fr
let r6 = fr ; sbf
let r7 = fsb ; fr ; sbf

let scp = r1|r2|r3|r4|r5|r6|r7

acyclic (((SC * SC) & scp) \ id) as Spartial

//undefined_unless empty dr as Dr
//undefined_unless empty ur as unsequencedRace
//undefined_unless empty bl as badLock
//undefined_unless empty lu as badUnlock

// Atomicity
empty rmw & (fre; coe) as atomic
let ur = int & ((W * M) | (M * W)) & loc & ~id & ~(sb+) & ~((sb+)^-1)

(* locks_only_good_mutex_use, locks_only_bad_mutexes *)
// let bl = ([ls]; (sb & lo); [lk]) & ~(lo; [ul]; lo)
// let losbwoul = (sb & lo & ~(lo; [UL]; lo))
// let lu = [UL] & ~([UL] ; losbwoul^-1 ; [LS] ; losbwoul ; [UL])

(* Simplified SC axioms *)
// This SC semantics is proposed in the paper "Overhauling SC atomics in C11 and OpenCL" section 3.2
// The proposal simplifies the Spartial and provide stronger guarantees
let scp = ((SC * SC) & (fsb?; (mo | fr | hb); sbf?)) \ id
acyclic scp as Ssimp
Loading
Loading