Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version number from jar files #504

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Remove version number from jar files #504

merged 1 commit into from
Aug 21, 2023

Conversation

hernanponcedeleon
Copy link
Owner

No description provided.

@hernan-poncedeleon
Remove version number from jar files
a21fe61 
Signed-off-by: Hernan Ponce de Leon <[email protected]>
@ThomasHaas
Copy link
Collaborator

Keep in mind that the CNA repo might also need an update to avoid the version number (if you want to keep that repo alive).

@hernanponcedeleon
Copy link
Owner Author

The CNA scrips checkout a concrete commit of dartagnan, so this should not cause any problem

ThomasHaas
ThomasHaas approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@ThomasHaas ThomasHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hernanponcedeleon hernanponcedeleon merged commit 241040d into development Aug 21, 2023
1 check passed
@hernanponcedeleon hernanponcedeleon deleted the jar_file branch August 21, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasHaas ThomasHaas ThomasHaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hernanponcedeleon @ThomasHaas @hernan-poncedeleon