Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tcp in the default features of hermit-sys #437

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Conversation

stlankes
Copy link
Contributor

@stlankes stlankes commented Jul 5, 2023

TCP is an important feature and should be part of the default features

Closes #435.

TCP is an important feature and should be part of the default features

This PR solves #435
@jounathaen
Copy link
Member

I'm not sure if we should add dhcpv4 then as well 🤔

@stlankes
Copy link
Contributor Author

stlankes commented Jul 9, 2023

At least for our CI tests is dhcpv4 not required.

@jounathaen
Copy link
Member

I'm not talking about the CI but about the user experience. Then a "microservice" would work out of the box.

@stlankes
Copy link
Contributor Author

stlankes commented Jul 9, 2023

Ok, I will change it.

@mkroening mkroening added this pull request to the merge queue Jul 23, 2023
Merged via the queue into master with commit 8040397 Jul 23, 2023
6 checks passed
@mkroening mkroening deleted the stlankes-patch-1 branch July 23, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include tcp in the default features of hermit-sys
3 participants