ci: add preview via fly #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5f9fceb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a765e9d.web-d91.pages.dev |
| Branch Preview URL: | https://issue-x-preview-via-fly.web-d91.pages.dev |
MaxSchaefer
force-pushed
the
issue/x-preview-via-fly
branch
12 times, most recently
from
42dcedf
to
13fbee8
Compare
MaxSchaefer
temporarily deployed
to
pr-634-tasks
GitHub Actions
Inactive
MaxSchaefer
force-pushed
the
issue/x-preview-via-fly
branch
6 times, most recently
from
864a904
to
c37ee15
Compare
MaxSchaefer
requested review from
shivadharmi and
Paul-B98
and removed request for
a team
MaxSchaefer
force-pushed
the
issue/x-preview-via-fly
branch
from
c37ee15
to
5f9fceb
Compare
felixevers
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request introduces the ability to preview projects of this monorepo on Fly.io. The solution proposed in #351 adopts
next-on-pages. I am following this repository closely, it seems like that this project is unstable.Therefore, I decided to go with https://github.com/superfly/fly-pr-review-apps. Projects inside this monorepo, that are already deployed via Fly.io are now able to deploy a preview environment in our
helpwave-stagingorga.I've tested the mentioned deployment via GitHub environments (a first-class feature to show the deployment state of branches), but this requires clean-up of already merged deployments. https://github.com/strumwolf/delete-deployment-environment should handle this, but I couldn't get it to run. Successful execution, no action. We're now just commenting the preview URL into the pr for now. TODO
Testing
See comment below
Closes #164
Closes #351