Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reenable duedate field #590

Merged
merged 8 commits into from
Aug 14, 2023
Merged

reenable duedate field #590

merged 8 commits into from
Aug 14, 2023

Conversation

DasProffi
Copy link
Member

Which issues does this pull request close?

closes #557

@DasProffi DasProffi self-assigned this Aug 6, 2023
@DasProffi DasProffi requested a review from a team as a code owner August 6, 2023 09:48
@DasProffi DasProffi requested review from felixevers and shivadharmi and removed request for a team August 6, 2023 09:48
@DasProffi DasProffi marked this pull request as draft August 6, 2023 09:48
@DasProffi
Copy link
Member Author

Waiting for a decision on how duedates are removed in the backend interface

@MaxSchaefer
Copy link
Member

Waiting for a decision on how duedates are removed in the backend interface

Please open this PR. The removal of due dates will be a future enhancement.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 8, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8df1b88
Status: ✅  Deploy successful!
Preview URL: https://5033fc9e.web-d91.pages.dev
Branch Preview URL: https://issue-557-due-date-for-task.web-d91.pages.dev

View logs

@DasProffi DasProffi marked this pull request as ready for review August 10, 2023 09:13
felixevers
felixevers previously approved these changes Aug 14, 2023
View reviewed changes
tasks/utils/timeConversion.ts Outdated Show resolved Hide resolved
tasks/utils/timeConversion.ts Outdated Show resolved Hide resolved
tasks/utils/timeConversion.ts Outdated Show resolved Hide resolved
@felixevers felixevers dismissed their stale review August 14, 2023 00:34

Now authorization problems seem to block functionality

felixevers
felixevers approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@felixevers felixevers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For initial creation setting the status to in progress or done changes nothing on creation. We need to grey that selection on creation or move it directly after it or even better on create.

@DasProffi it's up to you whether you want to fix it in this pull request or not. Please create and link a proper issue if you decide not to implement this in here.

@DasProffi
Copy link
Member Author

For initial creation setting the status to in progress or done changes nothing on creation. We need to grey that selection on creation or move it directly after it or even better on create.

@DasProffi it's up to you whether you want to fix it in this pull request or not. Please create and link a proper issue if you decide not to implement this in here.

Moved to seperate issue see #623

@DasProffi DasProffi merged commit a43a2e1 into main Aug 14, 2023
7 checks passed
@DasProffi DasProffi deleted the issue/557-Due-date-for-task branch August 14, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixevers felixevers felixevers approved these changes

@shivadharmi shivadharmi Awaiting requested review from shivadharmi shivadharmi is a code owner automatically assigned from helpwave/web

@MaxSchaefer MaxSchaefer Awaiting requested review from MaxSchaefer

Assignees

@DasProffi DasProffi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Due date for task
3 participants
@DasProffi @MaxSchaefer @felixevers