Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bed and room select #550

Closed
wants to merge 4 commits into from
Closed

bed and room select #550

wants to merge 4 commits into from

Conversation

DasProffi
Copy link
Member

Which issues does this pull request close?

closes #473

@DasProffi DasProffi self-assigned this Jul 29, 2023
@DasProffi
Copy link
Member Author

Functionality works, but the bed and room id isn't updated in the context

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 29, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8669b7c
Status: ✅  Deploy successful!
Preview URL: https://bc185ff3.web-d91.pages.dev
Branch Preview URL: https://issue-473-room-bed-dropdown.web-d91.pages.dev

View logs

@DasProffi DasProffi marked this pull request as ready for review July 30, 2023 15:25
@DasProffi DasProffi requested a review from a team as a code owner July 30, 2023 15:25
@DasProffi DasProffi requested review from MaxSchaefer and Paul-B98 and removed request for a team July 30, 2023 15:25
@DasProffi DasProffi changed the title add: bed and room select bed and room select Jul 30, 2023
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please fall back to vertical stacked inputs instead of scaling the height
  • The save indicator is always visible
  • Please add the room and bed labels above the inputs

Bildschirm­foto 2023-07-30 um 11 15 48 PM

@DasProffi
Copy link
Member Author

DasProffi commented Aug 1, 2023

The PR isn't updating so I will create a new one to hopefully fix this
see #573

@DasProffi DasProffi closed this Aug 1, 2023
@DasProffi DasProffi mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room/Bed dropdown on patient details view
2 participants