Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loading and error components #542

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Conversation

DasProffi
Copy link
Member

Which issues does this pull request close?

closes #532

@DasProffi DasProffi self-assigned this Jul 28, 2023
@DasProffi DasProffi requested a review from a team as a code owner July 28, 2023 18:23
@DasProffi DasProffi requested review from MaxSchaefer and shivadharmi and removed request for a team July 28, 2023 18:23
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 22ede83
Status: ✅  Deploy successful!
Preview URL: https://4818b05f.web-d91.pages.dev
Branch Preview URL: https://issue-532-loading-animation.web-d91.pages.dev

View logs

lib/icons/HelpwaveSpinner.tsx Outdated Show resolved Hide resolved
lib/icons/HelpwaveSpinner.tsx Outdated Show resolved Hide resolved
lib/components/ErrorComponent.tsx Show resolved Hide resolved
Copy link
Member

@felixevers felixevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to explain my view a bit different this time.

@DasProffi DasProffi merged commit 0213bc1 into main Jul 30, 2023
7 checks passed
@DasProffi DasProffi deleted the issue/532-Loading_animation branch July 30, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading animation
2 participants