Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin versions #485

Merged
merged 2 commits into from
Jul 7, 2023
Merged

pin versions #485

merged 2 commits into from
Jul 7, 2023

Conversation

DasProffi
Copy link
Member

Which issues does this pull request close?

closes #484

@DasProffi DasProffi requested a review from a team as a code owner July 4, 2023 09:46
@DasProffi DasProffi self-assigned this Jul 4, 2023
@DasProffi DasProffi requested review from felixevers and florian-sabonchi and removed request for a team July 4, 2023 09:46
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 4, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a3f1046
Status: ✅  Deploy successful!
Preview URL: https://f1a5ca61.web-d91.pages.dev
Branch Preview URL: https://issue-484-pin-versions.web-d91.pages.dev

View logs

MaxSchaefer
MaxSchaefer requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use https://docs.renovatebot.com/configuration-options/#rangestrategy instead of manually pinning the dependencies.

@felixevers
Copy link
Member

Yeah, this is pain, but shouldn't we just fix the issues after installing new packages instead?

@DasProffi
Copy link
Member Author

Yeah, this is pain, but shouldn't we just fix the issues after installing new packages instead?

That's the plan, but with the current changes to information passing with contexts and the backend integration, changing the code after a major update of the packages would be too much workload to make effective progress.

Therefore, we want to delay this for now by version pinning

@felixevers
Copy link
Member

felixevers commented Jul 7, 2023 •
edited
Loading

This pr currently has no progress. Is help wanted @DasProffi ?

@felixevers felixevers mentioned this pull request Jul 7, 2023
Merged
@DasProffi
Copy link
Member Author

This pr currently has no progress. Is help wanted @DasProffi ?

I discussed it with @MaxSchaefer he wanted to check my proposed versioning and then change the renovate config

@DasProffi DasProffi merged commit b3a6f77 into main Jul 7, 2023
7 checks passed
@DasProffi DasProffi deleted the issue/484-Pin_versions branch July 7, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxSchaefer MaxSchaefer MaxSchaefer approved these changes

@felixevers felixevers Awaiting requested review from felixevers felixevers is a code owner automatically assigned from helpwave/web

@florian-sabonchi florian-sabonchi Awaiting requested review from florian-sabonchi florian-sabonchi is a code owner automatically assigned from helpwave/web

Assignees

@DasProffi DasProffi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin versions
3 participants
@DasProffi @felixevers @MaxSchaefer