make Carousel slide and drag controllable #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying web with
|
| Latest commit: |
e53e8df
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1d1007a3.web-d91.pages.dev |
| Branch Preview URL: | https://issue-1071-slider-not-slidab.web-d91.pages.dev |
MaxSchaefer
approved these changes
Sep 5, 2024
MaxSchaefer
approved these changes
Sep 5, 2024
felixevers
previously requested changes
Sep 5, 2024
|
Please move all new changes after the approved commit to a new branch and reset this branch back to the already approved commit. So that we can merge this, gain value of the new slider and improve it further later on in a new pr. |
DasProffi
force-pushed
the
issue/1071-Slider_not_slidable_on_mobile
branch
from
95bd897
to
e53e8df
Compare
DasProffi
dismissed
felixevers’s stale review
Changes moved to a different PR
|
Changes in #1092 |
MaxSchaefer
added a commit
that referenced
this pull request
Sep 18, 2024
* fix(deps): update all non-major dependencies (#939) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: fix padding around product banner (#944) * fix: fix padding around product banner * fix: fix small gap * fix: add gap between text and button (#953) * chore: remove name sorting (#952) * feat: add delete task confirmation dialog (#950) * feat: remove default date for tasks (#949) * chore: update property tailwind use (#948) * fix: fix user switch not working (#961) * fix: fix width changes not being detected (#954) * feat: allow looking at discharged patients (#951) * feat: allow looking at discharged patients * chore: rename mutation variable Co-authored-by: Max Schäfer <[email protected]> * fix: rename all variable usages --------- Co-authored-by: Max Schäfer <[email protected]> * feat: add navigation to ward edit when ward is empty (#960) * feat: add navigation to ward edit when ward is empty * chore: update variable name * chore: remove update button on task details (#957) * feat: remove unnecessary update button on task details * chore: remove unused translation * feat: add TileWithImage (#968) * feat: add card with image example * feat: new component for image tiles * feat: add Profiles (#970) * feat: add Profiles * chore: change variable name * feat: update Expandable and add FAQSection (#969) * feat: update Expandable.tsx and add FAQSection * chore: use ExpandableProps for FAQItem * fix(deps): update all non-major dependencies (#962) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: fix one column in desktop layout (#958) * fix: fix one column in desktop layout * feat: keep hashtags grouped * chore: translate story and tasks page (#978) * chore: translate story and tasks page * Apply suggestions from code review Co-authored-by: Felix <[email protected]> --------- Co-authored-by: Felix <[email protected]> * feat: mediquu page (#985) * feat: add placeholderbrand page (#977) * feat: add placeholderbrand page * feat: add contact profiles to placeholderbrand page * fix: fix storybook * chore: remove unnecessary todo Co-authored-by: Max Schäfer <[email protected]> * chore: increase paddings --------- Co-authored-by: Max Schäfer <[email protected]> * feat: change assets and make layout responsive * chore: add faq content * refactor: reformat faq translations * chore: translating BrandInfo page * chore: translate contacts * fix: agreement icon * feat: override defaultLanguage to de for /mediquu page * chore: some markdown here and there * chore: mailto for mediQuu information page * fix: social links for mediQuu team * chore: replace mediquu email --------- Co-authored-by: Max Schäfer <[email protected]> * feat: update team section with new profile images (#976) * feat: update team section with new profile images * Update landing-page/components/TeamGroup.tsx * fix: fix image sizes --------- Co-authored-by: Max Schäfer <[email protected]> * feat: update acqusition texts * feat: add roadmap section * fix: apply linting * fix: Q5 to Q1 2025 (#990) * feat: update texts * fix: correct spelling mistakes * feat: add mediQuu CTA on start page (#995) * feat: add mediQuu CTA on start page * fix: typo * chore: fix wording and typos (#991) Co-authored-by: Max Schäfer <[email protected]> * fix: fix newLine in MarkdownInterpreter (#1000) * feat: add contact section (#987) * feat: add contact section * feat: integrate HubSpot form for mediQuu contact form * feat: integrate LoadingButton * feat: add success and error response to ContactSection --------- Co-authored-by: Max Schäfer <[email protected]> * fix: fix react error message (#994) * fix: fix react error message * feat: merge main and fix error message * fix: sition spelling mistake in german * feat: add more partners * feat: make landing page responsive (#1004) * feat: make landing page responsive * fix: fix type issue * fix: fix layout for story on main page * feat: add SectionBase for uniform section styling * chore: remove done todo Co-authored-by: Max Schäfer <[email protected]> * fix: fix linting --------- Co-authored-by: Max Schäfer <[email protected]> * fix(deps): update all non-major dependencies (#975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: add TextImage (#998) * feat: add TextImage * feat: merge main and update example image * feat: add custom scrollbar to partner section (#1025) * feat: add scrollbar to partner section * fix: fix scrollbar on desktop * feat: add partner 'Collective Incubator' * fix(deps): update all non-major dependencies (#1039) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: landing-page v2 (#1027) * chore: update header (#1058) * fix: fix double footer (#1068) * chore: update paddings (#1066) * feat: vision page steps to digitalization slider (#1042) * feat: update header (#1003) * feat: update header * chore: remove vision nav item and add contact link * feat: add story page header section (#1021) * feat: use sections * chore: remove border and shadow from header (#1032) * fix: hide mobile menu on tablet layout (#1036) * fix: fix overlapping scrollbar and add page template (#1038) * feat: add StepsToDigitalizationSection * fix: fix TextImage story * feat: add vision page partner section (#1033) * feat: update partner section * feat: add scroll to partner section * fix: fix import lint error * fix: fix linting * feat: add market stats section (#1030) * feat: update market stats section * chore: replace icons * feat: add vision section (#1044) * feat: add vision section * chore: translations * chore: remove todo --------- Co-authored-by: Max Schäfer <[email protected]> * chore: add en translation and lorem ipsum for de * feat: update tasks start section (#1022) * feat: update tasks start section * chore: translate en * fix: fix linting * feat: german translation and fix image not showing * chore: import only from one source Co-authored-by: Max Schäfer <[email protected]> --------- Co-authored-by: Max Schäfer <[email protected]> Co-authored-by: Max Schäfer <[email protected]> * feat: tasks product page trusted by section (#1045) * feat: add TrustedBySection * chore: update partners --------- Co-authored-by: Max Schäfer <[email protected]> * feat: add carousel component * feat: add custom Carousel component * feat: add animation to carousel component * feat: fix animation and add fade out * fix: fix overflow * feat: update vision page helpwave tasks (#1043) * feat: add tasksDemoSection * fix: fix image shadow * feat: update translations * feat: update translations and remove obsolete sections * feat: update layout in demo section * feat: add tasks feature sections (#1046) * feat: add feature section * feat: add other features to feature section * feat: update translations * fix: fix layout issues * feat: update translations * feat: make size more adaptive * feat: update images * fix: fix divider constructor * feat: update vision page header section (#1035) * feat: update vision header section * feat: update translations * feat: update image * feat: update image and layout * feat: update story page and add slider * feat: add modal to show cut off text * feat: credits page (#1050) * feat: credits page * chore: add more credits * fix: re-add podcast talks to menu * fix: wrap mediQuu page with Page component * chore: update texts of story page (#1053) * chore: update texts of story page * chore: comment trusted-by section out * fix: fix modal size * feat: limit modal width * feat: limit modal width on mobile * feat: update sliders --------- Co-authored-by: Max Schäfer <[email protected]> Co-authored-by: Max Schäfer <[email protected]> * feat: add centered shadow and use it (#1070) * feat: add centered shadow to twind config * feat: update shadow and apply it to profiles * chore: remove unused items from dom for modals (#1057) * fix: remove StoryInUseAt component from Story page (#1072) * chore: update @helpwave/proto-ts and removing /proto/ prefix (#1074) * chore: add information on mediquu transition (#1077) * feat: differentiate betweend title prefix and suffix on team members * feat: update title * feat: add mediquu link on landing page (#1080) * feat: add mediquu link on landing page * fix: linter --------- Co-authored-by: Max Schäfer <[email protected]> * fix: update LL.M to maître en droit * chore: use Flaticon icons (#1069) * feat: add Flaticon tag icon * feat: update icons and attribution links * fix: fix responsiveness for mediquu page (#1087) * feat: add adaptive titles for landing page (#1089) * chore: lower title additions * feat: add rwth logo to partner section (#1086) * chore: add rwth logo to partner section * chore: move RWTH to third place in partners list --------- Co-authored-by: Max Schäfer <[email protected]> * feat: make Carousel slide and drag controllable (#1088) * feat: make Carousel slide and drag controllable * fix: also use mobile touch events * fix: fix drag end not using changed touches * chore: rename home page * feat: update header and footer * chore: fix translation on subpage name * fix: remove spelling mistake Co-authored-by: Felix <[email protected]> * chore: increase menu width * feat: update background colors (#1065) * chore: update background colors * chore: merge main and correct carousel blur color * fix: fix styling on credits and join page * fix: fix selects not displaying properly for properties --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Felix <[email protected]> Co-authored-by: use-to <[email protected]> Co-authored-by: Christian Porschen <[email protected]> Co-authored-by: Felix Evers <[email protected]> Co-authored-by: Felix Evers <[email protected]> Co-authored-by: DasProffi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues does this pull request close?
closes #1071
[OPTIONAL] Give testing instructions to reviewers
Look at the preview of out landing page on the start screen there is a slider