desktopwindow: sort devices first #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not the nicest way, but it works and I couldn't find another way of sorting within the model. Essentially we stop the 'folder first' option for the desktop, as otherwise the 'mountpoint' devices are shown last after all the folders. Then we sort by owner, because devices happen to have a numeric value for the owner and the rest have the user's name. So they appear first... Signed-off-by: Chris Moore <[email protected]>
|
Thank you very much. This partially improves the issue; the intended behavior is described in #60 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not the nicest way, but it works and I couldn't find another way of sorting within the model. Essentially we stop the 'folder first' option for the desktop, as otherwise the 'mountpoint' devices are shown last after all the folders. Then we sort by owner, because devices happen to have a numeric value for the owner and the rest have the user's name. So they appear first...
Signed-off-by: Chris Moore [email protected]
#60
@probonopd please review