Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order items on the desktop, volumes should always be first #60

Closed
probonopd opened this issue Mar 28, 2021 · 4 comments
Closed

Order items on the desktop, volumes should always be first #60

probonopd opened this issue Mar 28, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed qt Qt expertise needed

Comments

@probonopd
Copy link
Member

This is a follow-up from #9.

Would it be possible to adjust the order a bit?

Ideally:

  • The "File System" icon (/, URL computer:///root.link) should always be the first one
  • Followed by any other disks (MIME type inode/mount-point, URL computer:///*.mount) ideally in the order of time when they were mounted (oldest mounts first)
  • Everything else, depending on the order set by the user

cc @moochris

@probonopd probonopd added enhancement New feature or request help wanted Extra attention is needed qt Qt expertise needed labels Mar 28, 2021
@ghost
Copy link

ghost commented Mar 28, 2021

Yeah, should be possible - I should have a bit more time next weekend to look at this and a few other things

@ghost
Copy link

ghost commented Mar 30, 2021

I realise I have just fixed the default ordering with that PR (which previously was modified date/time)

I don't really know how you would order the devices first in combination with the sort order chosen by the user.

@probonopd
Copy link
Member Author

Thanks for looking into this. Merging your PR, but it's not completely solved yet: Depending on what sort order the user chooses (e.g, by file type, by file name) it still can happen that the volumes are not in front of everything else.

To be clear, the intended behavior is that only the files and folders to be afftected by the sort order the user chooses. The combined model should not be sorted according to the user's choice. Volumes should always be first, and always in the order of when they were mounted.

@probonopd
Copy link
Member Author

Thanks @moochris for having resolved this issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed qt Qt expertise needed
Projects
None yet
Development

No branches or pull requests

1 participant