Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CompatMode #9

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix CompatMode #9

merged 1 commit into from
Oct 13, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Oct 13, 2023

Hermes subscribes Tendermint NewBlock event and cleans pending packets up every clear_interval blocks.
For this bug, when a new block has items incompatible with v0.34, the NewBlock event cannot be decoded.
That's why Hermes doesn't clean up pending packets.

@yito88 yito88 marked this pull request as ready for review October 13, 2023 14:51
@yito88 yito88 requested a review from Fraccaman October 13, 2023 14:52
@yito88 yito88 merged commit 526851f into 1.6.0-namada Oct 13, 2023
3 of 37 checks passed
@yito88 yito88 deleted the yuji/fix-namada-subscription branch October 13, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants