Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hermes misunderstood a Namada IBC transaction failed though it actually succeeded.
The issue could happen when another transaction fails in the same block where the IBC transaction is applied.
The cause is that
query_tx_events
caught unrelated failure transaction events.By this fix,
query_tx_events
checks the "code" of the transaction to know whether or not it has been applied.Only when the transaction has been applied successfully, IBC events are collected.