Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've detailed much more on #117 what the exact issue is.
But essentially, there were scopes expected to be present on the text of
script
from<script>
that was only applied to the<
and>
causingbracket-matcher
to only highlight the text if the cursor was near those ending characters, rather than on the entire piece of text.While I did talk with Pulsar maintainers if the best solution was to modify how
bracket-matcher
handles this, we came to the conclusion that it would make the most sense to instead fix the scopes being supplied by this grammar instead.So this PR fixes the underlighting of both
script
andstyle
by wrapping the full captures in the scope that was expected ofbracket-matcher
while leaving the internal captures alone, to keep syntax highlighting as expected.Before
After
Resolves #117