-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow a datetime.date
object to be used instead of datetime.datetime
for isodatetime data
#874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me` for isodatetime data
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #874 +/- ##
==========================================
+ Coverage 88.26% 88.28% +0.02%
==========================================
Files 45 45
Lines 9242 9242
Branches 2641 2641
==========================================
+ Hits 8157 8159 +2
+ Misses 766 765 -1
+ Partials 319 318 -1
☔ View full report in Codecov by Sentry. |
oruebel
added
category: enhancement
improvements of code or code behavior
priority: medium
non-critical problem and/or affecting only a small set of users
labels
Jul 7, 2023
rly
previously approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks.
rly
approved these changes
Jul 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: enhancement
improvements of code or code behavior
priority: medium
non-critical problem and/or affecting only a small set of users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix NeurodataWithoutBorders/nwb-schema#321
thoughts, @rly ?
Checklist
ruff
from the source directory.