Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow a datetime.date object to be used instead of datetime.datetime for isodatetime data #874

Merged
merged 10 commits into from
Jul 10, 2023

Conversation

bendichter
Copy link
Contributor

Motivation

fix NeurodataWithoutBorders/nwb-schema#321

thoughts, @rly ?

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@bendichter bendichter requested a review from rly June 16, 2023 16:26
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (6808826) 88.26% compared to head (884a93a) 88.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #874      +/-   ##
==========================================
+ Coverage   88.26%   88.28%   +0.02%     
==========================================
  Files          45       45              
  Lines        9242     9242              
  Branches     2641     2641              
==========================================
+ Hits         8157     8159       +2     
+ Misses        766      765       -1     
+ Partials      319      318       -1     
Impacted Files Coverage Δ
src/hdmf/spec/spec.py 90.86% <ø> (ø)
src/hdmf/build/builders.py 100.00% <100.00%> (ø)
src/hdmf/build/classgenerator.py 94.97% <100.00%> (ø)
src/hdmf/build/objectmapper.py 92.75% <100.00%> (+0.24%) ⬆️
src/hdmf/utils.py 96.41% <100.00%> (ø)
src/hdmf/validate/validator.py 84.10% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oruebel oruebel added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Jul 7, 2023
@oruebel oruebel added this to the Next Release milestone Jul 7, 2023
rly
rly previously approved these changes Jul 10, 2023
Copy link
Contributor

@rly rly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks.

@rly rly merged commit 6b1a55f into dev Jul 10, 2023
26 checks passed
@rly rly deleted the allow_date branch July 10, 2023 06:09
@rly rly removed this from the 3.14.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need field for specifying session start time accuracy
3 participants