Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better shape error message #787

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

bendichter
Copy link
Contributor

Motivation

fix NeurodataWithoutBorders/pynwb#1419

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b519aa) 88.65% compared to head (cd2c1a0) 88.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #787   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          45       45           
  Lines        9451     9452    +1     
  Branches     2688     2688           
=======================================
+ Hits         8379     8380    +1     
  Misses        757      757           
  Partials      315      315           
Files Coverage Δ
src/hdmf/utils.py 96.50% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter bendichter requested a review from rly November 10, 2022 19:49
@rly
Copy link
Contributor

rly commented Oct 27, 2023

I prefer "Any" instead of ":" to denote that any length is allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better shape check error in validator
2 participants