Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improperly set new vs overridden attributes #448

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 2, 2020

Motivation

Fix #447 .

Fix bug in BaseStorageSpec.resolve_spec where attributes are not correctly removed from the set of new attributes. __new_attributes contains just the field names but attribute is a field dictionary, so nothing was being removed.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly
Copy link
Contributor Author

rly commented Nov 2, 2020

The PyNWB test is failing and needs to be investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated container class has incorrect additional __fields__
1 participant