Fix #1148 : Add passthrough on non-DCI H5DataIO to support its use in pynwb TimeSeries. #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1149 +/- ##
==========================================
+ Coverage 88.91% 88.92% +0.01%
==========================================
Files 45 45
Lines 9857 9866 +9
Branches 2802 2806 +4
==========================================
+ Hits 8764 8773 +9
Misses 776 776
Partials 317 317 ☔ View full report in Codecov by Sentry. |
stephprince
reviewed
Aug 17, 2024
There was a problem hiding this comment.
Hi @cboulay, sorry for the delayed review. I added a couple of small suggestions but otherwise looks great. Thanks again for the PR!
|
Sorry, this fell off the radar. I'll look at it this evening. |
|
@stephprince , thank you for the suggestions. I incporporated all your suggested changes. |
stephprince
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1148
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
As explained in #1148 and pynwb #1929, when a
pynwb.TimeSeriesobject is created where (1) itsdatais aH5DataIOobject that DOES NOT wrap a DataChunkIterator, AND (2) itstimestampsare provided explicitly (vsrateandstarting_time), then theTimeSeriesobject crashes because it cannot access themaxshapeattribute on itsdatavalue.With this change, the
H5DataIOhas a newmaxshapeproperty which passes through the correct maxshape if known (either set during__init__or inferred from the dataset) elseNone, andpynwb.TimeSeriesno longer crashes.How to test the behavior?
I added a unit test in unit/test_io_hdf5_h5tools.py
Checklist
CHANGELOG.mdwith your changes?