MC-2989 - change MC version to 5.6-SNAPSHOT #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promanenko
requested review from
oliverhowell,
jgardiner68,
emrberk and
userMuratt
✅ Deploy Preview for frosty-curran-1fc0c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emrberk
approved these changes
Aug 16, 2024
userMuratt
approved these changes
Aug 16, 2024
JackPGreen
added a commit
to JackPGreen/management-center-docs
that referenced
this pull request
Aug 30, 2024
[The dead links checks in `hz-docs` are failing](https://github.com/hazelcast/hz-docs/actions/workflows/validate.yml). _One_ of the reasons for this is that the action checks out the default branch for all repos, builds the documentation and checks for linkage errors. The problem is that `hz-docs` is building `6.0-snapshot` docs, but the `management-center-docs` links are to `5.5.0`, which doesn't exist locally in this configuration. I believe this is why when `hz-docs`, so was [`management-center-docs`](hazelcast@36aa40a). This was subsequently reverted in hazelcast#355, which _I don't believe_ was intentional. _Partially fixes_: [DOC-125](https://hazelcast.atlassian.net/browse/DOC-125)
oliverhowell
added a commit
that referenced
this pull request
Sep 4, 2024
…360) [The dead links checks in `hz-docs` are failing](https://github.com/hazelcast/hz-docs/actions/workflows/validate.yml). _One_ of the reasons for this is that the action checks out the default branch for all repos, builds the documentation and checks for linkage errors. The problem is that `hz-docs` is building `6.0-snapshot` docs, but the `management-center-docs` links are to `5.5.0`, which doesn't exist locally in this configuration. I believe this is why when `hz-docs`'s version was upgraded, so was [`management-center-docs`, too](36aa40a). This was subsequently reverted in #355, which _I don't believe_ was intentional. _Partially fixes_: [DOC-125](https://hazelcast.atlassian.net/browse/DOC-125) [DOC-125]: https://hazelcast.atlassian.net/browse/DOC-125?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Oliver Howell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.