Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC-2875 Vector Collections #333

Merged
merged 12 commits into from
Aug 7, 2024
Merged

MC-2875 Vector Collections #333

merged 12 commits into from
Aug 7, 2024

Conversation

Sodik
Copy link
Contributor

@Sodik Sodik commented Jul 19, 2024

No description provided.

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for frosty-curran-1fc0c4 ready!

Name Link
🔨 Latest commit 95468b9
🔍 Latest deploy log https://app.netlify.com/sites/frosty-curran-1fc0c4/deploys/66b20a208ce6cf0008c277c4
😎 Deploy Preview https://deploy-preview-333--frosty-curran-1fc0c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zhmaeff
Copy link
Contributor

zhmaeff commented Jul 22, 2024

to be backported to 5.5.0

@zhmaeff zhmaeff requested a review from promanenko July 22, 2024 18:50
@promanenko
Copy link
Collaborator

please update the screenshots to be more realistic and display an actively used data structure, i.e.

  • created/updated/accessed time is not the same
  • not all throughput values are zero
  • charts are not flatlined

@jgardiner68
Copy link
Contributor

Not seeing Vector Collections in the navigation -- am I missing something?

@Sodik
Copy link
Contributor Author

Sodik commented Jul 23, 2024

Not seeing Vector Collections in the navigation -- am I missing something?

added

@Sodik
Copy link
Contributor Author

Sodik commented Jul 24, 2024

please update the screenshots to be more realistic and display an actively used data structure, i.e.

  • created/updated/accessed time is not the same
  • not all throughput values are zero
  • charts are not flatlined

done

@oliverhowell oliverhowell requested review from oliverhowell and removed request for rebekah-lawrence August 5, 2024 14:43
Copy link
Contributor

@oliverhowell oliverhowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick and dirty review but have left some suggestions and approving in advance!

Worth checking the section headings - it's worth adding these so they show in the right hand menu but the auto-generated links should be the same as you had initially specified.

docs/modules/data-structures/pages/vector-collection.adoc Outdated Show resolved Hide resolved
docs/modules/data-structures/pages/vector-collection.adoc Outdated Show resolved Hide resolved
docs/modules/data-structures/pages/vector-collection.adoc Outdated Show resolved Hide resolved
docs/modules/data-structures/pages/vector-collection.adoc Outdated Show resolved Hide resolved
docs/modules/data-structures/pages/vector-collection.adoc Outdated Show resolved Hide resolved
Comment on lines +122 to +123
[[vector-collection-throughput]]**Vector Collection Throughput Table** provides information about the operations
(get, put, remove) performed on each member in the vector collection, as shown below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=== Vector Collection Throughput
The **Vector Collection Throughput Table** provides information about the operations
(get, put, remove) performed on each member in the vector collection.

docs/modules/data-structures/pages/vector-collection.adoc Outdated Show resolved Hide resolved
docs/modules/data-structures/pages/vector-collection.adoc Outdated Show resolved Hide resolved
@Sodik Sodik merged commit 4fabfd8 into main Aug 7, 2024
6 checks passed
@Sodik Sodik deleted the feature/MC-2875 branch August 7, 2024 05:39
@oliverhowell
Copy link
Contributor

Arg, we forgot to add the backport label to this...I'll get this merged into 5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants