Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Tasks docs page [MC-962] #282

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

mehmettokgoz
Copy link
Contributor

@mehmettokgoz mehmettokgoz commented Nov 14, 2023

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for frosty-curran-1fc0c4 ready!

Name Link
🔨 Latest commit 5149ead
🔍 Latest deploy log https://app.netlify.com/sites/frosty-curran-1fc0c4/deploys/655742577dad0100088d7664
😎 Deploy Preview https://deploy-preview-282--frosty-curran-1fc0c4.netlify.app/management-center/5.4-snapshot/monitor-streaming/sql-tasks
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Here are the descriptions of columns:

* **Query:** SQL text of the query
* **Streaming Query:** Is the query bounded or not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we don't use bounded term for queries in the doc. I suggest to explain that it will be false for batch query

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,24 @@
= SQL Tasks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for SQLTasks.png it would be great to have at least one more batch query in the list for an example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Serdaro Serdaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmettokgoz mehmettokgoz merged commit be7fc4f into hazelcast:main Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants