Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal snapshot repository for OSS snapshot packages [DI-154][5.5.z] #209

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ldziedziul
Copy link
Contributor

Backport of #207

  • Use internal snapshot maven repository for getting OSS snapshot distribution zip
  • Do not produce brew packages for OSS snapshot as it would expose password-protected urls

Fixes https://hazelcast.atlassian.net/browse/DI-154

Implemented similar like hazelcast-docker: hazelcast/hazelcast-docker#774

@ldziedziul ldziedziul self-assigned this Jul 23, 2024
@nishaatr nishaatr changed the title Use internal snapshot repository for OSS snapshot packages [5.5.z] Use internal snapshot repository for OSS snapshot packages [DI-154][5.5.z] Jul 23, 2024
Copy link
Contributor

@nishaatr nishaatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, can you resolve #207 (comment)
Looks like it was fixed and its in this PR as well

@ldziedziul ldziedziul marked this pull request as ready for review July 23, 2024 12:59
@ldziedziul
Copy link
Contributor Author

For completeness, can you resolve #207 (comment) Looks like it was fixed and its in this PR as well

I've recreated this PR from the merged commit. Where do you see it? export HZ_SNAPSHOT_INTERNAL_PASSWORD is only in bash tests

@nishaatr
Copy link
Contributor

For completeness, can you resolve #207 (comment) Looks like it was fixed and its in this PR as well

I've recreated this PR from the merged commit. Where do you see it? export HZ_SNAPSHOT_INTERNAL_PASSWORD is only in bash tests

in the master PR #207 (comment)
It appears unresolved for me

image

@ldziedziul ldziedziul merged commit 36a10c9 into 5.5.z Jul 23, 2024
15 checks passed
@ldziedziul ldziedziul deleted the backport-pr-207-5.5.z branch July 23, 2024 13:09
JackPGreen pushed a commit that referenced this pull request Jul 30, 2024
….5.z] (#209)

Backport of #207

- Use internal snapshot maven repository for getting OSS snapshot
distribution zip
- Do not produce brew packages for OSS snapshot as it would expose
password-protected urls

Fixes https://hazelcast.atlassian.net/browse/DI-154

Implemented similar like hazelcast-docker:
hazelcast/hazelcast-docker#774
JackPGreen pushed a commit that referenced this pull request Jul 30, 2024
….5.z] (#209)

Backport of #207

- Use internal snapshot maven repository for getting OSS snapshot
distribution zip
- Do not produce brew packages for OSS snapshot as it would expose
password-protected urls

Fixes https://hazelcast.atlassian.net/browse/DI-154

Implemented similar like hazelcast-docker:
hazelcast/hazelcast-docker#774
JackPGreen pushed a commit that referenced this pull request Jul 30, 2024
….5.z] (#209)

Backport of #207

- Use internal snapshot maven repository for getting OSS snapshot
distribution zip
- Do not produce brew packages for OSS snapshot as it would expose
password-protected urls

Fixes https://hazelcast.atlassian.net/browse/DI-154

Implemented similar like hazelcast-docker:
hazelcast/hazelcast-docker#774
JackPGreen pushed a commit that referenced this pull request Jul 30, 2024
….5.z] (#209)

Backport of #207

- Use internal snapshot maven repository for getting OSS snapshot
distribution zip
- Do not produce brew packages for OSS snapshot as it would expose
password-protected urls

Fixes https://hazelcast.atlassian.net/browse/DI-154

Implemented similar like hazelcast-docker:
hazelcast/hazelcast-docker#774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants