Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[005] Upgrade Jackson jr version to get rid of null value bug #2459

Merged
merged 1 commit into from
Aug 26, 2020
Merged

[005] Upgrade Jackson jr version to get rid of null value bug #2459

merged 1 commit into from
Aug 26, 2020

Conversation

jbartok
Copy link
Contributor

@jbartok jbartok commented Aug 26, 2020 •
edited
Loading

When doing object mapping from JSON for CDC we've noticed that there is a problem with null values not being handled properly by Jackson jr (used by our JSON convenience code). This is the issue that has been submitted to them: FasterXML/jackson-jr#73. They have fixed the problem and now we need to upgrade to the fixed version. That's what this PR does.

Checklist

  • Tags Set
  • Milestone Set

@jbartok jbartok added enhancement cdc Change Data Capture labels Aug 26, 2020
@jbartok jbartok added this to the 4.3 milestone Aug 26, 2020
@jbartok jbartok self-assigned this Aug 26, 2020
@ghost
Copy link

ghost commented Aug 26, 2020

The job jet-oss-pr-builder of your PR failed (log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   TopologyChangeTest.when_coordinatorLeavesDuringExecution_then_nonCoordinatorJobSubmitterStillGetsJobResult:355 ? Completion
[INFO] 
[ERROR] Tests run: 2208, Failures: 0, Errors: 1, Skipped: 10
[INFO] 

[ERROR] There are test failures.

@jbartok
Copy link
Contributor Author

jbartok commented Aug 26, 2020

verify

frant-hartm
frant-hartm approved these changes Aug 26, 2020
View reviewed changes
Copy link
Collaborator

@frant-hartm frant-hartm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbartok jbartok merged commit a305f4d into hazelcast:master Aug 26, 2020
@jbartok jbartok deleted the jackson-jr-fix branch August 26, 2020 08:50
cangencer pushed a commit to cangencer/hazelcast-jet that referenced this pull request Aug 29, 2020
@jbartok @cangencer
[005] Upgrade Jackson jr version to get rid of null value bug (hazelc…
71f645b 
…ast#2459)
@jbartok jbartok mentioned this pull request Sep 2, 2020
Closed
@jbartok jbartok mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurbuzali gurbuzali gurbuzali approved these changes

@frant-hartm frant-hartm frant-hartm approved these changes

Assignees

@jbartok jbartok

Labels
cdc Change Data Capture enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbartok @gurbuzali @frant-hartm