Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ANTLR version to 4.13.1 and Java to 17 #88

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Update ANTLR version to 4.13.1 and Java to 17 #88

merged 4 commits into from
Jun 24, 2024

Conversation

TomaszGaweda
Copy link
Contributor

@TomaszGaweda TomaszGaweda commented Jun 18, 2024 •
edited
Loading

ANTLR 4.13.1 is needed by Debezium 2.x.

Java 17 is needed by ANTLR 4.13.1

@TomaszGaweda TomaszGaweda requested a review from kwart June 18, 2024 17:42
@TomaszGaweda TomaszGaweda changed the title Update ANTLR version to 4.13.1 Update ANTLR version to 4.13.1 and Java to 17 Jun 18, 2024
kwart
kwart approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@kwart kwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit in the compiler plugin config

pom.xml Outdated Show resolved Hide resolved
@TomaszGaweda @kwart
Update pom.xml
a26baa1 
Co-authored-by: Josef Cacek <[email protected]>
@TomaszGaweda TomaszGaweda merged commit d80b19b into hazelcast:master Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwart kwart kwart approved these changes

@frant-hartm frant-hartm frant-hartm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomaszGaweda @kwart @frant-hartm