-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): v0.0.7 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Woynert
commented
Oct 1, 2023
•
edited
Loading
edited
- Adds implementation for the download file RMI request using data streaming.
- From now on run tests on PRs agains main to being able to catch merge errors (should be active once this is merged).
* feat: Upload file write * feat: Write backup * feat: file size limits * feat: Add env vars and CLI.md * feat: Use env var to determine which volume to use * chore: Update rmi lib * feat: Config receive volume list * chore: Update RMI module name * fix: module import * chore: update submodule * feat: Add METADATA_BASEURL env var * feat: metadata service add request: mark file as ready * feat: Report file readiness when write is finished * feat: abort on write failure * fix: simplify http requests * fix: Use env var for Storage base path * feat: MetadataService saveFile * test: Util methods * Test: get config from env vars * test: FILE IO * chore: Update env vars default values * feat: Improve docker compose with only required services * ci: fix testing workflow * fix: Remove debug messages * feat: Update Dockerfile with setup script * fix: Coverage workflow * style: code format * chore: Add adminer service * docs: Add test intructions in README * fix: Expose RMI port in Dockerfile * fix: Make clearer config error msgs
* chore: Update some RMI types to use UUID * feat: Implement download-file method service with RMI streaming library * feat: Update RMI implementation with new downloadFile impl * feat(downloadFile): Fallback to backup when not found in files * chore: update submodule * test: Remove AppTest * test(downloadFile): better differentiate error types * feat: fetch file volume from metadata * test: downloadFile tests added * chore: update submodule * test: Add use case: Download file from backup * test: Further check if file is written un upload * test: rename test to use IT prefix
PedroChaparro
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.