docs(openapi): Update spec #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MiguelMRojas
commented
Oct 10, 2023
MiguelMRojas
commented
- Update OpenApi
PedroChaparro
requested changes
Oct 10, 2023
Done :) |
PedroChaparro
requested changes
Oct 10, 2023
There was a problem hiding this comment.
- There are some duplicated endpoints, Eg. POST
/file/uploadand POST/files. - The Bearer token should only be added to the endpoints that require authentication. For instance, the
/auth/loginand/account/registerdo not require authentication, while the/files/downloaddoes. - There are some endpoints with incorrect tags. For instance, the
account/registerendpoint should have theaccounttag.
Done, thanks for comment 💯 |
PedroChaparro
requested changes
Oct 10, 2023
PedroChaparro
approved these changes
Oct 12, 2023
Merged
MiguelMRojas
added a commit
that referenced
this pull request
Oct 14, 2023
* feat: Register endpoint (#39) * feat: enpoint registration coverage 57% Implementation of the registration endpoint, 57% coverage is achieved * style: Fix formatter and linter warnings * test: Use random data in register tests * refactor: Update register endpoint according to the `.net` spec * test: Fix broken test --------- Co-authored-by: Andvelavi <[email protected]> Co-authored-by: Pedro Andrés Chaparro Quintero <[email protected]> * fix: Enable all CORS origins (#44) * chore: Remove origins environment variable * fix: Enable all origins in CORS config * ci: Fix tagging pipeline (#48) * ci: Fix typo * feat: update docs openapi (#41) * feat: Endpoint to get the file status (#49) * refactor: Remove exception from responses * ci: Remove unnecessary field in tagging pipeline * fix: Update metadata base url in docker-compose * feat(file): Endpoint to get the state of a file * test(file): Add tests to the endpoint to get file state * chore: Set current version * feat: Endpoint to rename a file (#50) * feat: Update password (#51) * feat: Endpoint to update password + tests Endpoint to update password, with 42% coverage. Problems when querying with an invalid token * fix(account): Update endpoint to change the password * test(account): Update tests related to update password Increment coverage to 83% --------- Co-authored-by: Andvelavi <[email protected]> Co-authored-by: Pedro Andrés Chaparro Quintero <[email protected]> * feat: create a folder (#52) * feat: file upload (#53) * feat: file upload endpoint. Start of file upload endpoint , testing is still pending, in addition to possible changes according to the API update * feat: Progress and small corrections in upload_endpoint Progress is made in the endpoint in addition to correcting syntax and .py file creation problems * fix: upload file endpont corrections Corrections are made to the endpoint upload_file according to API update * fix: error message * fix: error messages in upload controller * feat: Create helper function to check if an UUID is valid * fix(files): Use multipart form data instead of JSON * test(files): Add success case test to the endpoint to upload files --------- Co-authored-by: Andvelavi <[email protected]> Co-authored-by: Pedro Andrés Chaparro Quintero <[email protected]> * fix(files): Keep files extension (#56) * test: Increment save file endpoint coverage (#54) * refactor(files): Remove unreachable block Since JSON is not being used in the endpoint, the block is unreachable * test(files): Increment upload handler coverage to 88% All lines, except the `500` status code error, are covered now --------- Co-authored-by: Antonio Donis <[email protected]> Co-authored-by: Pedro Andrés Chaparro Quintero <[email protected]> Co-authored-by: Pedro Andrés Chaparro Quintero <[email protected]> Co-authored-by: Andrea Velasquez <[email protected]> Co-authored-by: Andvelavi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.