Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable CORS #40

Merged
merged 5 commits into from
Oct 9, 2023
Merged

fix: Enable CORS #40

merged 5 commits into from
Oct 9, 2023

Conversation

MiguelMRojas
Copy link
Member

  • Enable the CORS setting in Flask (Python) to allow cross-origin requests (CORS) from http://localhost:5173 (React) in the context of authentication. This is required for authentication to work correctly in the local development environment.

@MiguelMRojas MiguelMRojas added the feature A new feature label Oct 9, 2023
@MiguelMRojas MiguelMRojas self-assigned this Oct 9, 2023
PedroChaparro
PedroChaparro requested changes Oct 9, 2023
View reviewed changes
main.py Outdated Show resolved Hide resolved
@PedroChaparro PedroChaparro changed the title feat: enable CORS for authentication on localhost fix: Enable CORS Oct 9, 2023
PedroChaparro
PedroChaparro approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@PedroChaparro PedroChaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash and merge :shipit:

@MiguelMRojas MiguelMRojas merged commit 3ba394f into dev Oct 9, 2023
3 checks passed
@MiguelMRojas MiguelMRojas deleted the feat/CORS branch October 9, 2023 17:43
@PedroChaparro PedroChaparro mentioned this pull request Oct 10, 2023
Merged
MiguelMRojas added a commit that referenced this pull request Oct 10, 2023
@MiguelMRojas @shoriwe
@PedroChaparro @AndreaVelasquezA @Andvelavi
Release: v0.0.9 (#42)
8417cac 
* fix: Enable CORS (#40)

* feat: Register endpoint (#39)

* feat: enpoint registration coverage 57%

Implementation of the registration endpoint, 57% coverage is achieved

* style: Fix formatter and linter warnings

* test: Use random data in register tests

* refactor: Update register endpoint according to the `.net` spec

* test: Fix broken test

---------

Co-authored-by: Antonio Donis <[email protected]>
Co-authored-by: Pedro Andrés Chaparro Quintero <[email protected]>
Co-authored-by: Pedro Andrés Chaparro Quintero <[email protected]>
Co-authored-by: Andrea Velasquez <[email protected]>
Co-authored-by: Andvelavi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedroChaparro PedroChaparro PedroChaparro approved these changes

Assignees

@MiguelMRojas MiguelMRojas

Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelMRojas @PedroChaparro