Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Register endpoint #39

Merged
merged 6 commits into from
Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/spec.openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ paths:
application/json:
schema:
$ref: "#/components/schemas/statusResponse"
/register:
/account/register:
post:
tags:
- Authentication
Expand Down Expand Up @@ -577,7 +577,7 @@ components:
authorization:
type: object
properties:
jwt:
token:
type: string
fileDetails:
type: object
Expand Down
31 changes: 31 additions & 0 deletions src/controllers/_account_controllers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
from flask import request
from src.config.soap_client import soap_client


def register_handler():
try:
# Get JSON data from the request
data = request.json

if not data:
return {"msg": "No JSON data provided in the request"}, 400

username = data.get("username")
password = data.get("password")

if not username or not password:
return {"msg": "Required fields are missing in JSON data"}, 400

result = soap_client.service.account_register(
{"username": username, "password": password}
)

if result.auth is not None:
jwt = result.auth.token
return {"msg": "Register succeeded", "token": jwt}, 200

return {"msg": "Username already registered"}, 409
AndreaVelasquezA marked this conversation as resolved.
Show resolved Hide resolved

except Exception as e:
print("[Exception] register_handler ->", str(e))
return {"msg": "Internal error", "error": str(e)}, 500
2 changes: 2 additions & 0 deletions src/views/__init__.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import flask
from ._authentication_views import views as authentication_views
from ._account_views import views as account_views


# NOTE: Register all views / routes using the following blueprint
views = flask.Blueprint("views", __name__)


views.register_blueprint(authentication_views)
views.register_blueprint(account_views)
9 changes: 9 additions & 0 deletions src/views/_account_views.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import flask
from src.controllers import _account_controllers

views = flask.Blueprint("account", __name__)


@views.route("/account/register", methods=["POST"])
def account_register():
return _account_controllers.register_handler()
48 changes: 48 additions & 0 deletions src/views/_account_views_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import json
from main import app
from src.lib.faker import fake_username, fake_password

register_test_data = {"username": fake_username(), "password": fake_password()}


def test_account_register_successful() -> None:
register_data = {
"username": register_test_data["username"],
"password": register_test_data["password"],
}
response = app.test_client().post("/account/register", json=register_data)
json_response = json.loads(response.data)

assert response.status_code == 200
assert json.loads(response.data)["msg"] == "Register succeeded"
assert json_response["token"] != ""


def test_account_register_missing_fields() -> None:
# Empty json
data = {}
response = app.test_client().post("/account/register", json=data)

assert response.status_code == 400
assert json.loads(response.data)["msg"] == "No JSON data provided in the request"

# Missing password
data = {"username": register_test_data["username"]}
response = app.test_client().post("/account/register", json=data)

assert response.status_code == 400
assert (
json.loads(response.data)["msg"] == "Required fields are missing in JSON data"
)


def test_account_register_Username_already_registered() -> None:
data = {
"username": register_test_data["username"],
"password": register_test_data["password"],
}
response = app.test_client().post("/account/register", json=data)
json_response = json.loads(response.data)

assert response.status_code == 409
assert json_response["msg"] == "Username already registered"