Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: endpoint challenge #33

Merged
merged 6 commits into from
Oct 8, 2023
Merged

feat: endpoint challenge #33

merged 6 commits into from
Oct 8, 2023

Conversation

MiguelMRojas
Copy link
Member

@MiguelMRojas MiguelMRojas commented Oct 6, 2023 •
edited
Loading

Closes #21

@MiguelMRojas MiguelMRojas self-assigned this Oct 6, 2023
@MiguelMRojas MiguelMRojas added the feature A new feature label Oct 6, 2023
@PedroChaparro PedroChaparro linked an issue Oct 6, 2023 that may be closed by this pull request
feat: Endpoint to verify and / or refresh the session #21
Closed
PedroChaparro
PedroChaparro requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@PedroChaparro PedroChaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, remember that the branch name should start with a semantic type like feat/, fix/, etc.

src/controllers/_authentication_controllers.py Outdated Show resolved Hide resolved
src/controllers/_authentication_controllers.py Outdated Show resolved Hide resolved
@MiguelMRojas
Copy link
Member Author

Also, remember that the branch name should start with a semantic type like feat/, fix/, etc.

OMG!, You're absolutely right, I overlooked it, it won't happen again

PedroChaparro
PedroChaparro requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@PedroChaparro PedroChaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing

PedroChaparro
PedroChaparro requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@PedroChaparro PedroChaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add another test to, at least, check if an existing token is valid. The following lines are not being tested according to the coverage report:

image

PedroChaparro
PedroChaparro approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@PedroChaparro PedroChaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash and merge :shipit:.

You can start using this in the React client, but keep in mind that we will need to create another pull request to follow the .net proxy specification.

@MiguelMRojas MiguelMRojas merged commit ee78fb6 into dev Oct 8, 2023
3 checks passed
@MiguelMRojas MiguelMRojas deleted the #21_endpoint_challenge branch October 8, 2023 23:28
@PedroChaparro PedroChaparro mentioned this pull request Oct 8, 2023
Merged
MiguelMRojas added a commit that referenced this pull request Oct 8, 2023
@MiguelMRojas @shoriwe @PedroChaparro
release: v0.0.7 (#34)
45d3519 
* docs: OpenApi Specification (#9)

* chore: Update docker-compose (#12)

* chore: Add missing env variables and services to docker-compose

* chore: Use worker default env variables

* ci: Linter and formatter (#14)

* chore: Add recommended vscode extensions

* chore(deps): Install black formatter and ruff linter

* style: Lint and format files

* docs: Add linting and formatting commands to README

* ci: Add linter and style checks to integration pipeline

* feat: endpoint login (#15)

* feat: endpoint challenge (#33)

---------

Co-authored-by: Antonio Donis <[email protected]>
Co-authored-by: Pedro Andrés Chaparro Quintero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedroChaparro PedroChaparro PedroChaparro approved these changes

@AndreaVelasquezA AndreaVelasquezA Awaiting requested review from AndreaVelasquezA

Assignees

@MiguelMRojas MiguelMRojas

Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Endpoint to verify and / or refresh the session
2 participants
@MiguelMRojas @PedroChaparro