Address command-line injection vulnerability #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `process` library on Windows is vulnerable to a command injection vulnerability, via `cmd.exe`'s interpretation of arguments. Processes that invoke batch files (`.bat`, `.cmd`) and pass arguments whose values are affected by program inputs may be affected. Add some additional escaping to neutralise this scenario. Also add some additional library documentation explaining how arguments are processed on Windows. Co-authored-By: Fraser Tweedale <[email protected]> HSEC-identifier: HSEC-2024-0003
|
Superceded by #312. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
processlibrary on Windows is vulnerable to a commandinjection vulnerability, via
cmd.exe's interpretation ofarguments. Processes that invoke batch files (
.bat,.cmd) andpass arguments whose values are affected by program inputs may be
affected.
Add some additional escaping to neutralise this scenario.
Also add some additional library documentation explaining how
arguments are processed on Windows.
Co-authored-By: Fraser Tweedale
HSEC-identifier: HSEC-2024-0003