Add SockOptValue and setSockOptValue
#588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinleyMcIlwaine
added a commit
to FinleyMcIlwaine/network-run
that referenced
this pull request
Sep 24, 2024
The existing interface did not allow one to set both `Linger` and `NoDelay` socket options. With the `SocketOptionValue` introduced in [this `network` PR](haskell/network#588), this is now possible.
kazu-yamamoto
requested changes
Sep 25, 2024
FinleyMcIlwaine
force-pushed
the
finley/existential-socket-option-values
branch
from
3893a87
to
2c2a445
Compare
|
That makes sense to me, I've updated this! |
FinleyMcIlwaine
force-pushed
the
finley/existential-socket-option-values
branch
from
2c2a445
to
39d6b8d
Compare
FinleyMcIlwaine
added a commit
to FinleyMcIlwaine/network-run
that referenced
this pull request
Sep 25, 2024
The existing interface did not allow one to set both `Linger` and `NoDelay` socket options. With the `SocketOptValue` introduced in [this `network` PR](haskell/network#588), this is now possible.
Network/Socket/Options.hsc
Outdated
| @@ -481,6 +500,12 @@ instance Storable StructLinger where | |||
| (#poke struct linger, l_linger) p linger | |||
| #endif | |||
|
|
|||
| -- | Existential socket option value | |||
There was a problem hiding this comment.
I feel that "existential" is too academic to understand for many users.
How about this?
"A data type to hold several different socket option types such as Int and StructLinger".
Please feel free to fix my broken English.
There was a problem hiding this comment.
Ah yes, thanks, I was also a bit worried about that. What you wrote sounds great, I'll update this!
FinleyMcIlwaine
force-pushed
the
finley/existential-socket-option-values
branch
from
39d6b8d
to
85a4b71
Compare
kazu-yamamoto
previously approved these changes
Sep 27, 2024
FinleyMcIlwaine
force-pushed
the
finley/existential-socket-option-values
branch
from
85a4b71
to
da15ef8
Compare
|
Whoops, sorry about that. Fixed! |
See docs for `setSockOptValue`
FinleyMcIlwaine
force-pushed
the
finley/existential-socket-option-values
branch
from
da15ef8
to
f0b472e
Compare
FinleyMcIlwaine
changed the title
SocketOptionValue and setSocketOptionValueSockOptValue and setSockOptValue
FinleyMcIlwaine
added a commit
to FinleyMcIlwaine/network-run
that referenced
this pull request
Sep 27, 2024
The existing interface did not allow one to set both `Linger` and `NoDelay` socket options. With the `SockOptValue` introduced in [this `network` PR](haskell/network#588), this is now possible.
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Sep 27, 2024
|
Merged. |
|
Looks good to me, thank you! |
|
A new version has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is to enable an interface in
network-runsimilar to theopen{Client,Server,TCPServer}SocketWithOptionsthat allows users to set multiple socket option values of potentially different value types, e.g.NoDelayandLinger. See the corresponding PR innetwork-run