Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the STM module. #586

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

kazu-yamamoto
Copy link
Collaborator

To implement network programming without asynchronous exceptions, this common pattern is useful.
@khibino Would you review this PR?

Copy link
Contributor

@khibino khibino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import Network.Socket.Shutdown
import Network.Socket.SockAddr
import Network.Socket.Syscall hiding (connect, bind, accept)
import Network.Socket.Syscall hiding (accept, bind, connect)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file formatting only?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Sorry. fourmolue did it automatically.

@kazu-yamamoto
Copy link
Collaborator Author

fourmole formatting has been pushed onto master.
Then the diff only for this issue has been pushed.

@kazu-yamamoto kazu-yamamoto merged commit 15e2454 into haskell:master Aug 28, 2024
13 of 14 checks passed
@kazu-yamamoto kazu-yamamoto deleted the socket-stm branch August 28, 2024 01:25
@kazu-yamamoto
Copy link
Collaborator Author

Thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants