Fix ghc and hlint warnings #568
Conversation
| & L.documentChanges . _Just . traversed %~ swapDocumentChangeUri | ||
|
|
||
| swapKeys :: (Uri -> Uri) -> M.Map Uri b -> M.Map Uri b |
There was a problem hiding this comment.
The only non-mechanical change, I just noticed and couldn't resist the simplifcation 😃
jhrcek
force-pushed
the
jhrcek/fix-warnings
branch
from
eb9a1b0
to
ec6b502
Compare
cabal.project
Outdated
| @@ -10,12 +10,15 @@ test-show-details: direct | |||
|
|
|||
| benchmarks: True | |||
|
|
|||
| package * | |||
| ghc-options: -Wunused-packages | |||
There was a problem hiding this comment.
Hmm. I think we normally put warning options in the cabal files, can we do that here too? Putting them all in cabal.project wouldn't be totally unreasonable, it's just inconsistent.
There was a problem hiding this comment.
I was just lazy 😄
But I agree and I moved it to cabal files + slightly consolidating using common warnings stanza and fixed few more warnings.
I hope there's nothing controversial, but will wait few days for your feedback (or let you merge if you think it's ok).
| @@ -53,7 +57,6 @@ library | |||
| GADTs | |||
| NegativeLiterals | |||
| OverloadedStrings | |||
| StandaloneKindSignatures | |||
There was a problem hiding this comment.
Removing this, as it's contained in GHC2021
|
Great, thanks! Just needs the formatting fixed. |
|
Fixed. Also noticed that I don't have right to merge (and I don't necessarily want them) so leaving merging up to you. |
No description provided.