Always try to register for didChangeConfiguration #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
force-pushed
the
mpj/dynamic-did-change-configuration
branch
from
42c31d3
to
c6a9b9b
Compare
|
Okay, this is ready to go now, I think.
|
|
Going to test this with HLS now. |
|
Got things working fine on HLS it seems, just need to get this green. |
|
BTW the explanation for the new behaviour is here: https://github.com/haskell/lsp/pull/548/files#diff-7ddecffae1af581bca5ca41258e9f1c668ae8cf3c80f1610cf6f5c34a9004e6eR538 |
The new direction of the spec seems to be that you should always do this. In any case, it doesn't hurt. `lsp-test` has some changes to adapt to the increased registration message spam, and also changes to be a more picky client, refusing to send notifications unless you _do_ register. This is good, since it forces us to handle the most annoying version of client behaviour.
michaelpj
force-pushed
the
mpj/dynamic-did-change-configuration
branch
from
6e9f082
to
300fdd6
Compare
soulomoon
pushed a commit
to soulomoon/lsp
that referenced
this pull request
Apr 8, 2024
* Register for workspace/didChangeConfiguration always The new direction of the spec seems to be that you should always do this. In any case, it doesn't hurt. `lsp-test` has some changes to adapt to the increased registration message spam, and also changes to be a more picky client, refusing to send notifications unless you _do_ register. This is good, since it forces us to handle the most annoying version of client behaviour. * Add bound on extra * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs some lsp-test work, but I think this should work.